TRT-2568: Revert "CCO-788: Remove kube-rbac-proxy container from metrics"#982
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@stbenjam: This pull request references CCO-788 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job 4.22 nightly aws-ovn-serial-1of2 |
|
@stbenjam: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job 4.22 nightly aws-ovn-techpreview-serial-1of3 |
|
@stbenjam: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
@stbenjam: This pull request references CCO-788 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
stbenjam
changed the title
|
@stbenjam: This pull request references TRT-2568 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/60ef6be0-1af1-11f1-9139-ca1df5029cef-0 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 46.19% 46.20% +0.01%
==========================================
Files 98 98
Lines 12256 12253 -3
==========================================
Hits 5662 5662
+ Misses 5944 5941 -3
Partials 650 650
🚀 New features to boost your workflow:
|
|
/lgtm Resolves the |
|
/verified by ci |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: neisw, stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
verified
|
@neisw: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label approved |
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-serial-1of2 |
|
@stbenjam: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/784a76a0-1b22-11f1-8f57-10277777bf8d-0 |
|
/payload-job abort |
|
@stbenjam: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
Hypershift is hitting another regression with CVO and AWS looks like a flake /override ci/prow/e2e-hypershift |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Revertomatic Revert
Why
This PR is causing blocking job failures in the 4.22 nightly amd64 payload. All serial and techpreview-serial blocking jobs fail with:
Error:
failed to ensure scraping target of pod openshift-cloud-credential-operator/cco-metrics requires auth: context deadline exceededThe PR removed kube-rbac-proxy from the CCO metrics endpoint and reimplemented RBAC via controller-runtime. The Prometheus auth test checks that metrics endpoints require authentication, and the CCO metrics endpoint now fails this check.
Failing Jobs
cc @jstuever