Skip to content

Commit e338ba6

Browse files
Merge pull request #982 from stbenjam/revert-976-payload-4.22.0-0.nightly-2026-03-08-004901
TRT-2568: Revert "CCO-788: Remove kube-rbac-proxy container from metrics"
2 parents 6b2f075 + 42d7c14 commit e338ba6

372 files changed

Lines changed: 34 additions & 80149 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

go.mod

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ require (
104104
github.com/aws/aws-sdk-go-v2/service/sts v1.41.6 // indirect
105105
github.com/beorn7/perks v1.0.1 // indirect
106106
github.com/blang/semver/v4 v4.0.0 // indirect
107-
github.com/cenkalti/backoff/v4 v4.3.0 // indirect
108107
github.com/cespare/xxhash/v2 v2.3.0 // indirect
109108
github.com/cncf/xds/go v0.0.0-20251014123835-2ee22ca58382 // indirect
110109
github.com/creack/pty v1.1.24 // indirect
@@ -154,7 +153,6 @@ require (
154153
github.com/googleapis/enterprise-certificate-proxy v0.3.6 // indirect
155154
github.com/googleapis/gax-go/v2 v2.15.0 // indirect
156155
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 // indirect
157-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 // indirect
158156
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
159157
github.com/hashicorp/go-retryablehttp v0.7.8 // indirect
160158
github.com/hinshun/vt10x v0.0.0-20220301184237-5011da428d02 // indirect
@@ -204,14 +202,11 @@ require (
204202
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 // indirect
205203
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 // indirect
206204
go.opentelemetry.io/otel v1.40.0 // indirect
207-
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 // indirect
208-
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 // indirect
209205
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.38.0 // indirect
210206
go.opentelemetry.io/otel/metric v1.40.0 // indirect
211207
go.opentelemetry.io/otel/sdk v1.40.0 // indirect
212208
go.opentelemetry.io/otel/sdk/metric v1.40.0 // indirect
213209
go.opentelemetry.io/otel/trace v1.40.0 // indirect
214-
go.opentelemetry.io/proto/otlp v1.7.0 // indirect
215210
go.yaml.in/yaml/v2 v2.4.3 // indirect
216211
go.yaml.in/yaml/v3 v3.0.4 // indirect
217212
golang.org/x/crypto v0.45.0 // indirect
@@ -234,7 +229,6 @@ require (
234229
k8s.io/gengo/v2 v2.0.0-20250922181213-ec3ebc5fd46b // indirect
235230
k8s.io/kube-aggregator v0.34.1 // indirect
236231
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect
237-
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 // indirect
238232
sigs.k8s.io/json v0.0.0-20250730193827-2d320260d730 // indirect
239233
sigs.k8s.io/kube-storage-version-migrator v0.0.6-0.20230721195810-5c8923c5ff96 // indirect
240234
sigs.k8s.io/randfill v1.0.0 // indirect

go.sum

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,6 @@ github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
184184
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
185185
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=
186186
github.com/blang/semver/v4 v4.0.0/go.mod h1:IbckMUScFkM3pff0VJDNKRiT6TG/YpiHIM2yvyW5YoQ=
187-
github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
188-
github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
189187
github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
190188
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
191189
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
@@ -443,8 +441,6 @@ github.com/gorilla/websocket v1.4.2/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/ad
443441
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 h1:JeSE6pjso5THxAzdVpqr6/geYxZytqFMBCOtn/ujyeo=
444442
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674/go.mod h1:r4w70xmWCQKmi1ONH4KIaBptdivuRPyosB9RmPlGEwA=
445443
github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7/go.mod h1:FecbI9+v66THATjSRHfNgh1IVFe/9kFxbXtjV0ctIMA=
446-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3 h1:5ZPtiqj0JL5oKWmcsq4VMaAW5ukBEgSGXEN89zeH1Jo=
447-
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.3/go.mod h1:ndYquD05frm2vACXE1nsccT4oJzjhw2arTS2cpUD1PI=
448444
github.com/hashicorp/go-cleanhttp v0.5.2 h1:035FKYIWjmULyFRBKPs8TBQoi0x6d9G4xc9neXJWAZQ=
449445
github.com/hashicorp/go-cleanhttp v0.5.2/go.mod h1:kO/YDlP8L1346E6Sodw+PrpBSV4/SoxCXGY6BqNFT48=
450446
github.com/hashicorp/go-hclog v1.6.3 h1:Qr2kF+eVWjTiYmU7Y31tYlP1h0q/X3Nl3tPGdaB11/k=
@@ -670,10 +666,6 @@ go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 h1:RbKq8BG
670666
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0/go.mod h1:h06DGIukJOevXaj/xrNjhi/2098RZzcLTbc0jDAUbsg=
671667
go.opentelemetry.io/otel v1.40.0 h1:oA5YeOcpRTXq6NN7frwmwFR0Cn3RhTVZvXsP4duvCms=
672668
go.opentelemetry.io/otel v1.40.0/go.mod h1:IMb+uXZUKkMXdPddhwAHm6UfOwJyh4ct1ybIlV14J0g=
673-
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0 h1:OeNbIYk/2C15ckl7glBlOBp5+WlYsOElzTNmiPW/x60=
674-
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.34.0/go.mod h1:7Bept48yIeqxP2OZ9/AqIpYS94h2or0aB4FypJTc8ZM=
675-
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0 h1:tgJ0uaNS4c98WRNUEx5U3aDlrDOI5Rs+1Vifcw4DJ8U=
676-
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.34.0/go.mod h1:U7HYyW0zt/a9x5J1Kjs+r1f/d4ZHnYFclhYY2+YbeoE=
677669
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.38.0 h1:wm/Q0GAAykXv83wzcKzGGqAnnfLFyFe7RslekZuv+VI=
678670
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.38.0/go.mod h1:ra3Pa40+oKjvYh+ZD3EdxFZZB0xdMfuileHAm4nNN7w=
679671
go.opentelemetry.io/otel/metric v1.40.0 h1:rcZe317KPftE2rstWIBitCdVp89A2HqjkxR3c11+p9g=
@@ -684,8 +676,6 @@ go.opentelemetry.io/otel/sdk/metric v1.40.0 h1:mtmdVqgQkeRxHgRv4qhyJduP3fYJRMX4A
684676
go.opentelemetry.io/otel/sdk/metric v1.40.0/go.mod h1:4Z2bGMf0KSK3uRjlczMOeMhKU2rhUqdWNoKcYrtcBPg=
685677
go.opentelemetry.io/otel/trace v1.40.0 h1:WA4etStDttCSYuhwvEa8OP8I5EWu24lkOzp+ZYblVjw=
686678
go.opentelemetry.io/otel/trace v1.40.0/go.mod h1:zeAhriXecNGP/s2SEG3+Y8X9ujcJOTqQ5RgdEJcawiA=
687-
go.opentelemetry.io/proto/otlp v1.7.0 h1:jX1VolD6nHuFzOYso2E73H85i92Mv8JQYk0K9vz09os=
688-
go.opentelemetry.io/proto/otlp v1.7.0/go.mod h1:fSKjH6YJ7HDlwzltzyMj036AJ3ejJLCgCSHGj4efDDo=
689679
go.uber.org/atomic v1.7.0/go.mod h1:fEN4uk6kAWBTFdckzkM89CLk9XfWZrxpCo0nPH17wJc=
690680
go.uber.org/goleak v1.1.10/go.mod h1:8a7PlsEVH3e/a/GLqe5IIrQx6GzcnRmZEufDUTk4A7A=
691681
go.uber.org/goleak v1.1.11/go.mod h1:cwTWslyiVhfpKIDGSZEM2HlOvcqm+tG4zioyIeLoqMQ=
@@ -1159,8 +1149,6 @@ k8s.io/utils v0.0.0-20260108192941-914a6e750570/go.mod h1:xDxuJ0whA3d0I4mf/C4ppK
11591149
rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
11601150
rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
11611151
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
1162-
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2 h1:jpcvIRr3GLoUoEKRkHKSmGjxb6lWwrBlJsXc+eUYQHM=
1163-
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.31.2/go.mod h1:Ve9uj1L+deCXFrPOk1LpFXqTg7LCFzFso6PA48q/XZw=
11641152
sigs.k8s.io/controller-runtime v0.22.2 h1:cK2l8BGWsSWkXz09tcS4rJh95iOLney5eawcK5A33r4=
11651153
sigs.k8s.io/controller-runtime v0.22.2/go.mod h1:+QX1XUpTXN4mLoblf4tqr5CQcyHPAki2HLXqQMY6vh8=
11661154
sigs.k8s.io/controller-tools v0.18.0 h1:rGxGZCZTV2wJreeRgqVoWab/mfcumTMmSwKzoM9xrsE=

manifests/02-networkpolicy-allow-ingress-metrics.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,8 @@ metadata:
1111
spec:
1212
ingress:
1313
- ports:
14-
- port: 8443
15-
protocol: TCP
16-
from:
17-
- namespaceSelector:
18-
matchLabels:
19-
name: openshift-monitoring
14+
- protocol: TCP
15+
port: 8443
2016
podSelector:
2117
matchExpressions:
2218
- key: app

manifests/03-deployment.yaml

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,33 @@ spec:
3434
seccompProfile:
3535
type: RuntimeDefault
3636
containers:
37+
- args:
38+
- --secure-listen-address=0.0.0.0:8443
39+
- --upstream=http://127.0.0.1:2112/
40+
- --tls-cert-file=/etc/tls/private/tls.crt
41+
- --tls-private-key-file=/etc/tls/private/tls.key
42+
- --logtostderr=true
43+
image: quay.io/openshift/origin-kube-rbac-proxy:latest
44+
imagePullPolicy: IfNotPresent
45+
name: kube-rbac-proxy
46+
securityContext:
47+
allowPrivilegeEscalation: false
48+
capabilities:
49+
drop: ["ALL"]
50+
readOnlyRootFilesystem: true
51+
ports:
52+
- containerPort: 8443
53+
name: metrics
54+
protocol: TCP
55+
resources:
56+
requests:
57+
memory: 20Mi
58+
cpu: 10m
59+
terminationMessagePath: /dev/termination-log
60+
terminationMessagePolicy: FallbackToLogsOnError
61+
volumeMounts:
62+
- mountPath: /etc/tls/private
63+
name: cloud-credential-operator-serving-cert
3764
- command:
3865
- /usr/bin/cloud-credential-operator
3966
- operator
@@ -54,10 +81,6 @@ spec:
5481
capabilities:
5582
drop: ["ALL"]
5683
readOnlyRootFilesystem: true
57-
ports:
58-
- containerPort: 8443
59-
name: metrics
60-
protocol: TCP
6184
resources:
6285
requests:
6386
cpu: 10m
@@ -66,8 +89,6 @@ spec:
6689
volumeMounts:
6790
- mountPath: /etc/pki/ca-trust/extracted/pem
6891
name: cco-trusted-ca
69-
- mountPath: /etc/tls/private
70-
name: cloud-credential-operator-serving-cert
7192
nodeSelector:
7293
node-role.kubernetes.io/master: ""
7394
priorityClassName: system-cluster-critical

manifests/image-references

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,7 @@ spec:
1818
from:
1919
kind: DockerImage
2020
Name: quay.io/openshift/gcp-workload-identity-federation-webhook
21+
- name: kube-rbac-proxy
22+
from:
23+
kind: DockerImage
24+
name: quay.io/openshift/origin-kube-rbac-proxy:latest

pkg/cmd/operator/cmd.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ import (
5353
ctrlruntimelog "sigs.k8s.io/controller-runtime/pkg/log"
5454
"sigs.k8s.io/controller-runtime/pkg/manager"
5555
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
56-
"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
5756
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
5857

5958
configv1 "github.com/openshift/api/config/v1"
@@ -247,10 +246,7 @@ func NewOperator() *cobra.Command {
247246
ByObject: objectSelectors,
248247
},
249248
Metrics: metricsserver.Options{
250-
BindAddress: ":8443",
251-
SecureServing: true,
252-
FilterProvider: filters.WithAuthenticationAndAuthorization,
253-
CertDir: "/etc/tls/private",
249+
BindAddress: ":2112",
254250
},
255251
PprofBindAddress: ":6060",
256252
})

vendor/github.com/cenkalti/backoff/v4/.gitignore

Lines changed: 0 additions & 25 deletions
This file was deleted.

vendor/github.com/cenkalti/backoff/v4/LICENSE

Lines changed: 0 additions & 20 deletions
This file was deleted.

vendor/github.com/cenkalti/backoff/v4/README.md

Lines changed: 0 additions & 30 deletions
This file was deleted.

vendor/github.com/cenkalti/backoff/v4/backoff.go

Lines changed: 0 additions & 66 deletions
This file was deleted.

0 commit comments

Comments
 (0)