Skip to content

MCO-2293: adds RHEL10 featuregate #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cheesesashimi wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

MCO-2293: adds RHEL10 featuregate #2860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
| EventedPLEG| | | | | | | | |
| MachineAPIOperatorDisableMachineHealthCheckController| | | | | | | | |
| MultiArchInstallAzure| | | | | | | | |
| RHEL10| | | | | | | | |
| ShortCertRotation| | | | | | | | |
| ClusterAPIComputeInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
| ClusterAPIControlPlaneInstall| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | | |
Expand Down
8 changes: 8 additions & 0 deletions features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,14 @@ var (
enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
mustRegister()

FeatureGateRHEL10 = newFeatureGate("RHEL10").
reportProblemsToJiraComponent("MachineConfigOperator").
contactPerson("zzlotnik").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1874").
enable(inVersion(5, greaterThanOrEqual)).
mustRegister()

FeatureGateCRDCompatibilityRequirementOperator = newFeatureGate("CRDCompatibilityRequirementOperator").
reportProblemsToJiraComponent("Cloud Compute / Cluster API Providers").
contactPerson("ddonati").
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
Comment on lines +251 to +253
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Static disable conflicts with version-gated enablement.

RHEL10 is enabled in features/features.go at Line 891 for version >=5, but this 4-10 manifest hard-disables it in the only status entry (version: ""). That mismatch can keep 5+ behavior/docs incorrect. Please represent RHEL10 with version-specific status entries (or equivalent per-major manifest split) so 4.x and 5+ resolve differently.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml`
around lines 251 - 253, The manifest currently hard-disables the "RHEL10"
feature with a single status entry (version: "") which conflicts with the
code-enabled RHEL10 for >=5; update the 4-10 feature-gate manifest so RHEL10 has
version-specific status entries (e.g., an explicit disabled entry for versions
<5 and either no entry or an enabled entry for versions >=5) or split into
per-major manifests so 4.x keeps it disabled and 5+ resolves to enabled,
ensuring the unique feature name "RHEL10" is adjusted accordingly in the
manifest entries to match the version-gated behavior in features.go.

{
"name": "SELinuxMount"
},
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@
{
"name": "OLMLifecycleAndCompatibility"
},
{
"name": "RHEL10"
},
{
"name": "ShortCertRotation"
}
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
{
"name": "SELinuxMount"
},
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
{
"name": "ShortCertRotation"
},
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
{
"name": "SELinuxMount"
},
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
{
"name": "MultiArchInstallAzure"
},
{
"name": "RHEL10"
},
{
"name": "ShortCertRotation"
}
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
{
"name": "SELinuxMount"
},
Expand Down
3 changes: 3 additions & 0 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
{
"name": "ProvisioningRequestAvailable"
},
{
"name": "RHEL10"
},
{
"name": "ShortCertRotation"
},
Expand Down