MCO-2293: adds RHEL10 featuregate

[cheesesashimi]

The intent behind this FeatureGate is to enable RHEL10 by default in OCP 5.0 while allowing OCP 4.23 to opt into it, if desired. As of right now, there are still a few TODOs and tweaks that need to be done for this to have the desired effect.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@cheesesashimi: This pull request references MCO-2293 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The intent behind this FeatureGate is to enable RHEL10 by default in OCP 5.0 while allowing OCP 4.23 to opt into it, if desired. As of right now, there are still a few TODOs and tweaks that need to be done for this to have the desired effect.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces the RHEL10 feature gate to the OpenShift API. The change adds a new exported feature gate definition FeatureGateRHEL10 in features/features.go configured to enable in version 5 and above, documents the gate in the feature matrix table (features.md), and registers it as a disabled feature gate across all eight FeatureGate manifests covering different deployment profiles (Hypershift and SelfManagedHA) and release channels (Default, DevPreviewNoUpgrade, OKD, TechPreviewNoUpgrade).

Suggested reviewers

• everettraven
• memodi

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding a RHEL10 feature gate, which aligns with the changeset modifications across feature definitions and manifests.
Description check	✅ Passed	The description is directly related to the changeset, explaining the intent behind the RHEL10 feature gate for OCP 5.0 and OCP 4.23 compatibility.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR does not modify any Ginkgo test files; it only changes feature gate documentation, source code, and YAML configuration files. Check is not applicable.
Test Structure And Quality	✅ Passed	PR adds only feature gate definition and configuration files with no Ginkgo test code; check not applicable.
Microshift Test Compatibility	✅ Passed	PR does not add Ginkgo e2e tests. Changes are limited to feature gate definitions, documentation, and YAML configuration. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only adds feature gate configuration and documentation, not Ginkgo e2e tests. SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds only feature gate registration and configuration. No deployment manifests, operator code, controllers, or scheduling constraints are introduced, so the topology check is not applicable.
Ote Binary Stdout Contract	✅ Passed	PR only adds feature gate variable definition in features/features.go var block using builder chain that doesn't write to stdout. No main(), init(), or suite code added. YAML files are configuration.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR; only feature gate definitions and configuration files are modified. Check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @cheesesashimi! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml`:
- Around line 251-253: The manifest currently hard-disables the "RHEL10" feature
with a single status entry (version: "") which conflicts with the code-enabled
RHEL10 for >=5; update the 4-10 feature-gate manifest so RHEL10 has
version-specific status entries (e.g., an explicit disabled entry for versions
<5 and either no entry or an enabled entry for versions >=5) or split into
per-major manifests so 4.x keeps it disabled and 5+ resolves to enabled,
ensuring the unique feature name "RHEL10" is adjusted accordingly in the
manifest entries to match the version-gated behavior in features.go.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e7d6492b-243b-4292-a92d-66ba7822f8d4

📥 Commits

Reviewing files that changed from the base of the PR and between 09730f8 and 016b634.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

[coderabbitai]

⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Static disable conflicts with version-gated enablement.

RHEL10 is enabled in features/features.go at Line 891 for version >=5, but this 4-10 manifest hard-disables it in the only status entry (version: ""). That mismatch can keep 5+ behavior/docs incorrect. Please represent RHEL10 with version-specific status entries (or equivalent per-major manifest split) so 4.x and 5+ resolve differently.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml`
around lines 251 - 253, The manifest currently hard-disables the "RHEL10"
feature with a single status entry (version: "") which conflicts with the
code-enabled RHEL10 for >=5; update the 4-10 feature-gate manifest so RHEL10 has
version-specific status entries (e.g., an explicit disabled entry for versions
<5 and either no entry or an enabled entry for versions >=5) or split into
per-major manifests so 4.x keeps it disabled and 5+ resolves to enabled,
ensuring the unique feature name "RHEL10" is adjusted accordingly in the
manifest entries to match the version-gated behavior in features.go.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment