Skip to content

Fix undefined variable in openmc.mgxs.library (scatt_mgxs) #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 3 commits into from
May 30, 2026
+244 −5
Merged

Fix undefined variable in openmc.mgxs.library (scatt_mgxs) #3943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b395d26
fix: define scatt_mgxs
hugo-barthod May 23, 2026
5708ab1
Add test in tests/regression_tests/mgxs_library_ce_to_mg
hugo-barthod May 25, 2026
6e1f405
Style fixes
paulromano May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions openmc/mgxs/library.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1290,6 +1290,14 @@ def get_xsdata(self, domain, xsdata_name, nuclide='total', xs_type='macro',
'are ignored since multiplicity or nu-scatter matrices '\
'were not tallied for ' + xsdata_name
warn(msg, RuntimeWarning)

if 'scatter matrix' in self.mgxs_types:
scatt_mgxs = self.get_mgxs(domain, 'scatter matrix')
elif 'consistent scatter matrix' in self.mgxs_types:
scatt_mgxs = self.get_mgxs(domain, 'consistent scatter matrix')
else:
raise ValueError(f'No scatter matrix found for {xsdata_name}.')

xsdata.set_scatter_matrix_mgxs(scatt_mgxs, temperature=temperature,
xs_type=xs_type,
nuclide=[nuclide],
Expand Down
0 ...sts/mgxs_library_ce_to_mg/inputs_true.dat → ...to_mg/inputs_true_multiplicity_matrix.dat
View file
Open in desktop
File renamed without changes.
217 changes: 217 additions & 0 deletions tests/regression_tests/mgxs_library_ce_to_mg/inputs_true_scatter_matrix.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,217 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material id="7" name="UO2 (2.4%)" depletable="true">
<density value="10.29769" units="g/cm3"/>
<nuclide name="U234" ao="4.4843e-06"/>
<nuclide name="U235" ao="0.00055815"/>
<nuclide name="U238" ao="0.022408"/>
<nuclide name="O16" ao="0.045829"/>
</material>
<material id="8" name="Zircaloy">
<density value="6.55" units="g/cm3"/>
<nuclide name="Zr90" ao="0.021827"/>
<nuclide name="Zr91" ao="0.00476"/>
<nuclide name="Zr92" ao="0.0072758"/>
<nuclide name="Zr94" ao="0.0073734"/>
<nuclide name="Zr96" ao="0.0011879"/>
</material>
<material id="9" name="Hot borated water">
<density value="0.740582" units="g/cm3"/>
<nuclide name="H1" ao="0.049457"/>
<nuclide name="O16" ao="0.024672"/>
<nuclide name="B10" ao="8.0042e-06"/>
<nuclide name="B11" ao="3.2218e-05"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<cell id="4" name="Fuel" material="7" region="-7" universe="0"/>
<cell id="5" name="Cladding" material="8" region="7 -8" universe="0"/>
<cell id="6" name="Water" material="9" region="8 9 -10 11 -12" universe="0"/>
<surface id="7" name="Fuel OR" type="z-cylinder" coeffs="0 0 0.39218"/>
<surface id="8" name="Clad OR" type="z-cylinder" coeffs="0 0 0.4572"/>
<surface id="9" name="left" type="x-plane" boundary="reflective" coeffs="-0.63"/>
<surface id="10" name="right" type="x-plane" boundary="reflective" coeffs="0.63"/>
<surface id="11" name="bottom" type="y-plane" boundary="reflective" coeffs="-0.63"/>
<surface id="12" name="top" type="y-plane" boundary="reflective" coeffs="0.63"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>10</batches>
<inactive>5</inactive>
<source type="independent" strength="1.0" particle="neutron">
<space type="box">
<parameters>-0.63 -0.63 -1 0.63 0.63 1</parameters>
</space>
<constraints>
<fissionable>true</fissionable>
</constraints>
</source>
</settings>
<tallies>
<filter id="43" type="material">
<bins>7</bins>
</filter>
<filter id="44" type="energy">
<bins>0.0 0.625 20000000.0</bins>
</filter>
<filter id="49" type="energyout">
<bins>0.0 0.625 20000000.0</bins>
</filter>
<filter id="53" type="legendre">
<order>3</order>
</filter>
<filter id="54" type="material">
<bins>8</bins>
</filter>
<filter id="65" type="material">
<bins>9</bins>
</filter>
<tally id="76">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="77">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>total</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="78">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="79">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>absorption</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="80">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="81">
<filters>43 44 49</filters>
<nuclides>total</nuclides>
<scores>nu-fission</scores>
<estimator>analog</estimator>
</tally>
<tally id="82">
<filters>43 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="83">
<filters>43 44 49 53</filters>
<nuclides>total</nuclides>
<scores>scatter</scores>
<estimator>analog</estimator>
</tally>
<tally id="84">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="85">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>total</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="86">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="87">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>absorption</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="88">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="89">
<filters>54 44 49</filters>
<nuclides>total</nuclides>
<scores>nu-fission</scores>
<estimator>analog</estimator>
</tally>
<tally id="90">
<filters>54 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="91">
<filters>54 44 49 53</filters>
<nuclides>total</nuclides>
<scores>scatter</scores>
<estimator>analog</estimator>
</tally>
<tally id="92">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="93">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>total</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="94">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="95">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>absorption</scores>
<estimator>tracklength</estimator>
</tally>
<tally id="96">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="97">
<filters>65 44 49</filters>
<nuclides>total</nuclides>
<scores>nu-fission</scores>
<estimator>analog</estimator>
</tally>
<tally id="98">
<filters>65 44</filters>
<nuclides>total</nuclides>
<scores>flux</scores>
<estimator>analog</estimator>
</tally>
<tally id="99">
<filters>65 44 49 53</filters>
<nuclides>total</nuclides>
<scores>scatter</scores>
<estimator>analog</estimator>
</tally>
</tallies>
</model>
24 changes: 19 additions & 5 deletions tests/regression_tests/mgxs_library_ce_to_mg/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


class MGXSTestHarness(PyAPITestHarness):
def __init__(self, *args, **kwargs):
def __init__(self, *args, scatter_mgxs_type=None, **kwargs):
# Generate inputs using parent class routine
super().__init__(*args, **kwargs)

Expand All @@ -19,8 +19,8 @@ def __init__(self, *args, **kwargs):
# Initialize MGXS Library for a few cross section types
self.mgxs_lib = openmc.mgxs.Library(self._model.geometry)
self.mgxs_lib.by_nuclide = False
self.mgxs_lib.mgxs_types = ['total', 'absorption', 'nu-fission matrix',
'nu-scatter matrix', 'multiplicity matrix']
self.mgxs_lib.mgxs_types = ['total', 'absorption', 'nu-fission matrix']
self.mgxs_lib.mgxs_types += scatter_mgxs_type
self.mgxs_lib.energy_groups = energy_groups
self.mgxs_lib.correction = None
self.mgxs_lib.legendre_order = 3
Expand Down Expand Up @@ -69,9 +69,23 @@ def _cleanup(self):
os.remove(f)


def test_mgxs_library_ce_to_mg():
def test_mgxs_library_ce_to_mg_multiplicity_matrix():
# Set the input set to use the pincell model
model = pwr_pin_cell()

harness = MGXSTestHarness('statepoint.10.h5', model)
harness = MGXSTestHarness(
'statepoint.10.h5', model,
inputs_true='inputs_true_multiplicity_matrix.dat',
scatter_mgxs_type=['nu-scatter matrix', 'multiplicity matrix']
)
harness.main()


def test_mgxs_library_ce_to_mg_scatter_matrix():
# Set the input set to use the pincell model
model = pwr_pin_cell()

harness = MGXSTestHarness('statepoint.10.h5', model,
inputs_true='inputs_true_scatter_matrix.dat',
scatter_mgxs_type=['scatter matrix'])
harness.main()
Loading