Skip to content

Fix undefined variable in openmc.mgxs.library (scatt_mgxs)#3943

Open
hugo-barthod wants to merge 3 commits into
openmc-dev:developfrom
hugo-barthod:fix-scatt_matrix
Open

Fix undefined variable in openmc.mgxs.library (scatt_mgxs)#3943
hugo-barthod wants to merge 3 commits into
openmc-dev:developfrom
hugo-barthod:fix-scatt_matrix

Conversation

@hugo-barthod
Copy link
Copy Markdown

Description

In openmc.mgxs.library, lines 1286-1292 suggest it okay to build a multigroup library from only a scatter matrix (ie without multiplicity being accounted for).
However when reaching these lines, scatt_mgxs was undefined variable and raised error.
This PR defines scatt_mgxs in this case.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten added the Bugs label May 26, 2026
Copy link
Copy Markdown
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugo-barthod!

@paulromano paulromano enabled auto-merge (squash) May 30, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants