8274893: Update java.desktop classes to use try-with-resources by TimPushkin · Pull Request #686 · openjdk/jdk8u-dev

TimPushkin · 2025-09-01T07:36:51Z

Backport of JDK-8274893 for parity with Oracle's JDK 8u461.

Resolved conflicts:

jdk/src/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java
- Missing JDK-8271456: "ISO-8859-1" string is used instead of ISO_8859_1 enum constant
- Missing JDK-8041679: StringBuffer is used instead of StringBuilder
jdk/src/share/classes/javax/swing/text/html/HTMLEditorKit.java
- Missing JDK-8271456: "ISO-8859-1" string is used instead of ISO_8859_1 enum constant
jdk/src/share/classes/com/sun/media/sound/StandardMidiFileWriter.java
- Missing JDK-8143909: no Objects.requireNonNull(...) in this version
jdk/src/solaris/classes/sun/awt/motif/MFontConfiguration.java
- Missing JDK-8054834: imports from sun.font package are still needed in this file
jdk/src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java
- Missing JDK-8080835: use IOUtils.readAllBytes(InputStream is) instead of the missing InputStream.readAllBytes()
Missing JDK-7196163: try-with-resources cannot be used with pre-existing variables — fell back to try-finally in such cases

Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64)

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
JDK-8274893 needs maintainer approval
Commit message must refer to an issue

Issue

JDK-8274893: Update java.desktop classes to use try-with-resources (Enhancement - P5 - Approved)

Reviewers

Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/686/head:pull/686
$ git checkout pull/686

Update a local copy of the PR:
$ git checkout pull/686
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 686

View PR using the GUI difftool:
$ git pr show -t 686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/686.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-01T07:37:43Z

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-01T07:38:43Z

@TimPushkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274893: Update java.desktop classes to use try-with-resources

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

3728209: 8377344: [8u] Compilation failure on Windows for Linux-specific platform metric tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-09-01T07:38:58Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2025-09-01T07:42:11Z

Webrevs

turbanoff · 2025-09-01T10:40:38Z

            return null;
-        try
-        {
+        try {


There should be try-with-resources

There was in the original change but in this JDK try-with-resources on an existing variable is not possible (no JDK-7196163), so I fell back to try-finally. This is not the only place where I've done this, see 832c3c3.

Alternatives are to either create a copy variable for try-with-resources (which also must be used inside it to prevent a compiler warning) or move all interactions with the variable inside try-with-resources — both diverge code from the original change and the pre-existing code so I decided against them.

Shouldn't we revert formatting changes here, then?

I wasn't sure what would be the best here: keeping the existing formatting to changing it to be closer to the backported change — and went with the latter.

Since I don't really have a strong preference, reverted to the old one now as you suggest.

TimPushkin · 2025-09-01T14:46:34Z

I believe test failures are not related

bridgekeeper · 2025-09-30T09:04:47Z

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

TimPushkin · 2025-09-30T09:07:06Z

/touch

openjdk · 2025-09-30T09:07:31Z

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2025-10-28T14:46:19Z

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

TimPushkin · 2025-10-28T15:05:49Z

/touch

openjdk · 2025-10-28T15:07:28Z

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2025-11-26T05:44:51Z

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

TimPushkin · 2025-11-26T06:27:53Z

/touch

openjdk · 2025-11-26T06:28:14Z

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2025-12-24T10:39:33Z

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

TimPushkin · 2025-12-24T10:46:41Z

/touch

openjdk · 2025-12-24T10:47:23Z

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750

openjdk · 2025-12-26T11:09:16Z

@TimPushkin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

TimPushkin · 2025-12-26T12:25:45Z

Rebased on top of the current master

bridgekeeper · 2026-01-23T22:08:16Z

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

TimPushkin · 2026-01-26T18:01:41Z

/keepalive

openjdk · 2026-01-26T18:02:17Z

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

gnu-andrew

Mostly looks good to me. Just a few comments:

For the case in com.sun.media.sound.JARSoundbankReader.java, only a null check is outside the try block. Could that not be moved inside and the block converted to try-with-resources?
For the is case in com.sun.media.sound.SoftSynthesizer.java, could we not move the is declaration into a try-with-resources block? The only use outside thetry is a null check.

The other cases I think we are stuck with try-finally blocks.

TimPushkin · 2026-02-09T12:10:08Z

The test failures don't seem related:

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 is the one failed in almost all of the cases ("Failed to validate https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com/") — there was already JDK-8333937 some time ago with a similar error (not in the description but in the comments) and it was resolved externally
compiler/5091921/Test7005594.java failed twice ("Test7005594.sh: 40: Bad substitution") — already reported as JDK-8376951
gc/logging/TestGCId.java failed once (timeout)

gnu-andrew · 2026-02-11T02:25:37Z

The test failures don't seem related:

I agree.

* `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5` is the one failed in almost all of the cases ("Failed to validate https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com/") —  there was already [JDK-8333937](https://bugs.openjdk.org/browse/JDK-8333937) some time ago with a similar error (not in the description but in the comments) and it was resolved externally

I've seen this one on my own recent PRs (e.g. openjdk/shenandoah-jdk8u#122) and it seems to have turned up this weekend.

* `compiler/5091921/Test7005594.java` failed twice ("Test7005594.sh: 40: Bad substitution") — already reported as [JDK-8376951](https://bugs.openjdk.org/browse/JDK-8376951)

This should be resolved once #755 goes in.

* `gc/logging/TestGCId.java` failed once (timeout)

I think this is a sporadic failure and can't see a HotSpot test failure being related to these JDK code changes.

gnu-andrew

Thanks for the additional changes. You managed to cover more cases than I expected and it looks good.

openjdk · 2026-02-11T02:26:53Z

⚠️ @TimPushkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

TimPushkin · 2026-02-11T06:38:33Z

/approval request Backporting for parity with Oracle and to make a dependent in-progress backport cleaner.
Low risk. The change is a cleanup limited to multimedia classes (jdk.desktop in newer JDKs), it should not change the behavior.
Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64).

openjdk · 2026-02-11T06:40:09Z

@TimPushkin
8274893: The approval request has been created successfully.

gnu-andrew · 2026-02-11T16:12:59Z

/approve yes

openjdk · 2026-02-11T16:16:36Z

@gnu-andrew
8274893: The approval request has been approved.

TimPushkin · 2026-02-11T17:57:35Z

/integrate

openjdk · 2026-02-11T18:00:02Z

@TimPushkin
Your change (at version bdb9a1e) is now ready to be sponsored by a Committer.

gnu-andrew · 2026-02-18T01:35:34Z

/sponsor

openjdk · 2026-02-18T01:36:34Z

Going to push as commit d043a24.
Since your change was applied there have been 2 commits pushed to the master branch:

97fdbd0: 8170464: Remove shell script from compiler/c2/cr7005594/Test7005594.java
3728209: 8377344: [8u] Compilation failure on Windows for Linux-specific platform metric tests

Your commit was automatically rebased without conflicts.

openjdk · 2026-02-18T01:36:43Z

@gnu-andrew @TimPushkin Pushed as commit d043a24.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk Bot changed the title ~~Backport 70c6df6be431fe11c5441986ed04040f9ec3b750~~ 8274893: Update java.desktop classes to use try-with-resources Sep 1, 2025

openjdk Bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 1, 2025

openjdk Bot mentioned this pull request Sep 1, 2025

8347911: Limit the length of inflated text chunks #687

Closed

4 tasks

turbanoff reviewed Sep 1, 2025

View reviewed changes

8274893: Update java.desktop classes to use try-with-resources

fd9a023

Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750

TimPushkin force-pushed the 8274893-jdk8 branch from 3fd18e4 to fd9a023 Compare December 26, 2025 11:08

gnu-andrew suggested changes Feb 6, 2026

View reviewed changes

TimPushkin and others added 2 commits February 9, 2026 08:55

Use try-with-resources in more cases

b446b5a

Merge remote-tracking branch 'openjdk-jdk8/master' into 8274893-jdk8

bdb9a1e

TimPushkin requested a review from gnu-andrew February 9, 2026 12:13

gnu-andrew approved these changes Feb 11, 2026

View reviewed changes

openjdk Bot added the approval Requires approval; will be removed when approval is received label Feb 11, 2026

openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 11, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 11, 2026

openjdk Bot added the integrated Pull request has been integrated label Feb 18, 2026

openjdk Bot closed this Feb 18, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 18, 2026

Conversation

TimPushkin commented Sep 1, 2025 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Sep 1, 2025

Uh oh!

openjdk Bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Sep 1, 2025

Uh oh!

mlbridge Bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

turbanoff Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

TimPushkin Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

turbanoff Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

TimPushkin Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

TimPushkin commented Sep 1, 2025

Uh oh!

bridgekeeper Bot commented Sep 30, 2025

Uh oh!

TimPushkin commented Sep 30, 2025

Uh oh!

openjdk Bot commented Sep 30, 2025

Uh oh!

bridgekeeper Bot commented Oct 28, 2025

Uh oh!

TimPushkin commented Oct 28, 2025

Uh oh!

openjdk Bot commented Oct 28, 2025

Uh oh!

bridgekeeper Bot commented Nov 26, 2025

Uh oh!

TimPushkin commented Nov 26, 2025

Uh oh!

openjdk Bot commented Nov 26, 2025

Uh oh!

bridgekeeper Bot commented Dec 24, 2025

Uh oh!

TimPushkin commented Dec 24, 2025

Uh oh!

openjdk Bot commented Dec 24, 2025

Uh oh!

openjdk Bot commented Dec 26, 2025

Uh oh!

TimPushkin commented Dec 26, 2025

Uh oh!

bridgekeeper Bot commented Jan 23, 2026

Uh oh!

TimPushkin commented Jan 26, 2026

Uh oh!

openjdk Bot commented Jan 26, 2026

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

TimPushkin commented Feb 9, 2026

Uh oh!

gnu-andrew commented Feb 11, 2026

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk Bot commented Feb 11, 2026

Uh oh!

TimPushkin commented Feb 11, 2026

TimPushkin commented Sep 1, 2025 •

edited by openjdk Bot

Loading

openjdk Bot commented Sep 1, 2025 •

edited

Loading

mlbridge Bot commented Sep 1, 2025 •

edited

Loading