8347911: Limit the length of inflated text chunks

[TimPushkin]

Backport of JDK-8347911 for parity with Oracle's JDK 8u461.

Conflicts:

• Copyright years
• Missing JDK-8139206: use IOUtils.readNBytes(...) instead of the missing InputStream.readNBytes(...)

Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347911 needs maintainer approval

Issue

• JDK-8347911: Limit the length of inflated text chunks (Bug - P3 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/687/head:pull/687
$ git checkout pull/687

Update a local copy of the PR:
$ git checkout pull/687
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 687

View PR using the GUI difftool:
$ git pr show -t 687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/687.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into pr/686 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TimPushkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8347911: Limit the length of inflated text chunks

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• b647fb8: 8375063: Update Libpng to 1.6.54

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full (5d487eed)
• 02: Full (83fa86fc)
• 01: Full - Incremental (ab0f8cd2)
• 00: Full (ab0f8cd2)

[TimPushkin]

I believe the test failures are not related

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/touch

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/touch

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/touch

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/touch

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[openjdk]

@TimPushkin this pull request can not be integrated into pr/686 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8347911-jdk8
git fetch https://git.openjdk.org/jdk8u-dev.git pr/686
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/686"
git push

[openjdk]

@TimPushkin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[TimPushkin]

Rebased on top of the current master.

The CI failure is a single unrelated GC test, already reported as JDK-8303159.

[bridgekeeper]

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/keepalive

[openjdk]

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

[gnu-andrew]

I'll review this one once #686 is in.

[gnu-andrew]

I agree the test failure seems unrelated to this change.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8347911-jdk8
git fetch https://git.openjdk.org/jdk8u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@TimPushkin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[TimPushkin]

Rebased without changes to the commit being backported

[jerboaa]

This looks good to me.

[openjdk]

⚠️ @TimPushkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[TimPushkin]

/approval request Backporting for parity with Oracle.
Low risk: the change is limited to image IO, conflicts are minor.
Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64)

[openjdk]

@TimPushkin
8347911: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8347911: The approval request has been approved.

[TimPushkin]

/integrate

[openjdk]

@TimPushkin
Your change (at version 5d487ee) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 829387f.
Since your change was applied there has been 1 commit pushed to the master branch:

• b647fb8: 8375063: Update Libpng to 1.6.54

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @TimPushkin Pushed as commit 829387f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.