Skip to content

fix: add safe enterprise context defaults to survive stale Mako cache after PR #38094 #38642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+10 −1
Closed

fix: add safe enterprise context defaults to survive stale Mako cache after PR #38094 #38642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f152ee
Initial plan
Copilot May 14, 2026
8b5632c
fix: add safe enterprise context defaults to prevent stale Mako cache…
Copilot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions common/djangoapps/student/views/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,15 @@ def student_dashboard(request): # pylint: disable=too-many-statements
context = {
'urls': urls,
'programs_data': programs_data,
# These enterprise-related keys are populated by DashboardContextEnricher (via DashboardRenderStarted filter)
# when the enterprise package is installed. Safe defaults are provided here so that:
# 1. The template renders safely on non-enterprise deployments.
# 2. Any stale compiled Mako cache that still references consent_required_courses (from before
# PR #38094 removed that line) will not crash with "argument of type 'Undefined' is not iterable".
'enterprise_message': '',
'consent_required_courses': set(),
'enterprise_learner_portal_enabled_message': None,
'banner_account_activation_message': None,
'enrollment_message': enrollment_message,
'redirect_message': Text(redirect_message),
'account_activation_messages': account_activation_messages,
Expand Down
2 changes: 1 addition & 1 deletion lms/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3292,7 +3292,7 @@ def _should_send_certificate_events(settings):
"pipeline": ["enterprise.filters.accounts.AccountSettingsReadOnlyFieldsStep"],
},
"org.openedx.learning.dashboard.render.started.v1": {
"fail_silently": False,
"fail_silently": True,
"pipeline": ["enterprise.filters.dashboard.DashboardContextEnricher"],
},
}
Expand Down