Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/agents/tracing/processors.py
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,12 @@ def _sanitize_for_openai_tracing_api(self, payload_item: dict[str, Any]) -> dict

def _value_json_size_bytes(self, value: Any) -> int:
try:
serialized = json.dumps(value, ensure_ascii=False, separators=(",", ":"))
serialized = json.dumps(
value,
ensure_ascii=False,
separators=(",", ":"),
allow_nan=False,
)
except (TypeError, ValueError):
return self._OPENAI_TRACING_MAX_FIELD_BYTES + 1
return len(serialized.encode("utf-8"))
Expand Down
39 changes: 39 additions & 0 deletions tests/test_trace_processor_nonfinite_fields.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import math

import pytest

from agents.tracing.processors import BackendSpanExporter


@pytest.mark.parametrize("non_finite", [float("nan"), float("inf"), float("-inf")])
@pytest.mark.parametrize("field_name", ["input", "output"])
def test_openai_tracing_sanitizes_non_finite_span_fields(
non_finite: float, field_name: str
) -> None:
exporter = BackendSpanExporter(api_key="test_key")
original = {"finite": 1.5, "invalid": non_finite}
payload = {
"object": "trace.span",
"span_data": {"type": "generation", field_name: original},
}

sanitized = exporter._sanitize_for_openai_tracing_api(payload)

assert sanitized["span_data"][field_name] == {"finite": 1.5}
assert sanitized is not payload
assert math.isfinite(original["finite"])
assert not math.isfinite(original["invalid"])
exporter.close()


@pytest.mark.parametrize("field_name", ["input", "output"])
def test_openai_tracing_keeps_small_finite_span_fields(field_name: str) -> None:
exporter = BackendSpanExporter(api_key="test_key")
field = {"score": 1.25, "nested": [0.0, -4.5]}
payload = {
"object": "trace.span",
"span_data": {"type": "generation", field_name: field},
}

assert exporter._sanitize_for_openai_tracing_api(payload) is payload
exporter.close()