fix(tracing): sanitize non-finite span payloads - #4556
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
Conversation
Member
|
Closing this for the reason at #4551 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes OpenAI tracing normalization so non-finite float values cannot bypass the existing JSON sanitizer merely because the surrounding
inputoroutputfield is small.BackendSpanExporter._value_json_size_bytes()now measures payloads using strict JSON semantics withallow_nan=False. A field containingNaN,Infinity, or-Infinitytherefore follows the existing unserializable-value path, where_sanitize_json_compatible_value()removes the invalid nested value before the tracing payload is sent. Finite JSON payloads keep the existing fast path and are unchanged.The change deliberately reuses the current OpenAI-ingest sanitization boundary instead of introducing another recursive traversal. Focused regression coverage exercises both
inputandoutput, all three non-finite float forms, preservation of valid sibling data, and a finite control case.This pull request resolves #4551.