Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/agents/realtime/model.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import abc
import math
from collections.abc import Callable

from typing_extensions import NotRequired, TypedDict
Expand Down Expand Up @@ -57,12 +58,18 @@ def on_play_ms(self, item_id: str, item_content_index: int, ms: float) -> None:
item_content_index: The index of the audio content in `item.content`
ms: The number of milliseconds of audio that have been played.
"""
if not math.isfinite(ms) or ms < 0:
raise ValueError("Playback duration must be a finite, non-negative number.")

if self._current_item != (item_id, item_content_index):
new_elapsed_ms = ms
self._current_item = (item_id, item_content_index)
self._elapsed_ms = ms
else:
assert self._elapsed_ms is not None
self._elapsed_ms += ms
new_elapsed_ms = self._elapsed_ms + ms
if not math.isfinite(new_elapsed_ms):
raise ValueError("Playback duration total must be finite.")
self._elapsed_ms = new_elapsed_ms

def on_interrupted(self) -> None:
"""Called by the model when the audio playback has been interrupted."""
Expand Down
23 changes: 23 additions & 0 deletions tests/realtime/test_playback_tracker.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import math
from unittest.mock import AsyncMock, patch

import pytest
Expand All @@ -17,6 +18,28 @@ def model(self):
"""Create a fresh model instance for each test."""
return OpenAIRealtimeWebSocketModel()

@pytest.mark.parametrize("duration", [-1.0, math.nan, math.inf, -math.inf])
def test_tracker_rejects_invalid_playback_duration(self, duration: float) -> None:
tracker = RealtimePlaybackTracker()

with pytest.raises(ValueError, match="finite, non-negative"):
tracker.on_play_ms("item", 0, duration)

assert tracker.get_state() == {
"current_item_id": None,
"current_item_content_index": None,
"elapsed_ms": None,
}

def test_tracker_rejects_overflowing_playback_total(self) -> None:
tracker = RealtimePlaybackTracker()
tracker.on_play_ms("item", 0, 1e308)

with pytest.raises(ValueError, match="total must be finite"):
tracker.on_play_ms("item", 0, 1e308)

assert tracker.get_state()["elapsed_ms"] == 1e308

@pytest.mark.asyncio
async def test_interrupt_timing_with_custom_playback_tracker(self, model):
"""Test interrupt uses custom playback tracker elapsed time instead of default timing."""
Expand Down