fix: validate realtime playback durations - #4546
Closed
hsusul wants to merge 1 commit into
Closed
Conversation
Member
|
The added tests establish that validation can be implemented, but they do not demonstrate an unmet supported use case or exercise the claimed interruption failure through the public session path. I am going to close this PR for now. If a realistic playback integration can produce an invalid duration during ordinary use, please provide that code path and its observable session impact so we can reconsider the narrowest appropriate boundary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RealtimePlaybackTracker.on_play_msaccepted negative, non-finite, and overflowing cumulative playback durations. A later interruption could then fail while converting the invalid elapsed time to the integeraudio_end_mssent to Realtime. This change validates each duration and the prospective cumulative total before mutating tracker state.Test plan
NaN, positive/negative infinity, and cumulative float overflow.tests/realtime/test_playback_tracker.py: 26 passed..agents/skills/code-change-verification/scripts/run.sh: format, lint, typecheck, and full tests passed.git diff --check: passed.Issue number
Not linked to an issue; this is a directly reproducible public playback-tracker boundary bug.
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR