Conversation
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex Apps file parameters use a three-step upload flow: create a file record, PUT bytes to a returned signed URL, and finalize the upload. Each step still constructed a default
reqwestclient, so the flow could bypassfeatures.respect_system_proxyeven after model API requests honored it.This stack entry makes the resolved client policy a required input to the upload API and resolves each concrete destination independently.
What changed
HttpClientFactoryinupload_openai_file.ClientBuilderror when enabled route selection cannot construct a client.ReqwestDefaultpolicy.Review guide
codex-api/src/files.rschanges the upload API and centralizes route-aware client construction.core/src/mcp_openai_file.rsis the only production caller and supplies the turn configuration factory.Validation
cargo check --tests -p codex-api -p codex-corejust test -p codex-api files(1 matching upload test passed; 135 tests skipped by filter)just fix -p codex-api -p codex-coreFollow-up
Other direct HTTP clients remain separate migration slices.
Stack created with Sapling. Best reviewed with ReviewStack.