Conversation
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ModelClientalready carries theHttpClientFactoryresolved from session configuration, but realtime call creation and memory summarization still constructed the legacy default client directly. Consequently, those first-party API requests could ignorefeatures.respect_system_proxyeven when Responses traffic honored it.These are the final direct default-client constructions in
core/src/client.rs, so they form one small migration unit on top of #31361.What changed
build_responses_transporttobuild_api_transport./realtime/callsdestination./memories/trace_summarizethrough the same helper.build_reqwest_clientimport.Review guide
core/src/client.rsis mechanical and keeps existing Responses behavior unchanged.api_provider_override.Validation
cargo check --tests -p codex-corejust fix -p codex-coreFollow-up
Direct HTTP clients outside
ModelClientremain separate migration slices.Stack created with Sapling. Best reviewed with ReviewStack.