feat(next-prompt): add suggestion engine [1 of 3] by fcoury-oai · Pull Request #24126 · openai/codex

fcoury-oai · 2026-05-22T18:45:47Z

Why

The next-prompt feature needs a small core-owned suggestion engine before any app-server API or TUI wiring can depend on it. Keeping this layer separate lets reviewers evaluate the prompt construction, suppression rules, and context extraction without schema or UI noise.

What changed

Add codex_core::next_prompt_suggestion for prompt construction, output filtering, and suppression of weak or unsafe suggestions.
Add lightweight loaded-history turn context helpers used by the suggestion engine.
Expose the core helper through CodexThread without adding app-server protocol or TUI behavior in this PR.

Testing

cargo test -p codex-core next_prompt_suggestion
CARGO_TARGET_DIR=/private/tmp/codex-next-suggestion-stack-target ./tools/argument-comment-lint/run.py -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-tui

Stack

feat(next-prompt): add suggestion engine [1 of 3] #24126 next-prompt suggestion engine (this PR)
#24127 next-prompt app-server RPC
#23976 next-prompt TUI

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b05999569c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-22T19:31:18Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 67e04fa8bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-22T20:48:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ea7930ea5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-05-22T22:37:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6bde0aca71

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-05-22T22:58:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0d7b8e4cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury · 2026-05-22T23:45:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2da3ea1c10

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T00:04:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c5aff3b82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T00:18:56Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 374560d16f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T00:35:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3a7434cae4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T00:46:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e07878eda5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-23T00:50:31Z

Security review completed. No security issues were found in this pull request.

View security finding report

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

fcoury-oai · 2026-05-23T00:59:15Z

@codex review

chatgpt-codex-connector · 2026-05-23T01:03:48Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T01:04:31Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4711e33215

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai · 2026-05-23T01:49:56Z

@codex review

chatgpt-codex-connector · 2026-05-23T01:53:28Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fcoury-oai requested a review from a team as a code owner May 22, 2026 18:45

This was referenced May 22, 2026

feat(app-server): add next prompt suggestion RPC [2 of 3] #24127

Open

feat(tui): render next prompt suggestions [3 of 3] #23976

Open

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fcoury-oai changed the title ~~feat(next-prompt): add suggestion engine~~ feat(next-prompt): add suggestion engine [1 of 3] May 22, 2026

fcoury-oai force-pushed the fcoury/next-suggestion-core branch from b059995 to 67e04fa Compare May 22, 2026 19:25

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 67e04fa to 5ea7930 Compare May 22, 2026 20:16

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 5ea7930 to 6bde0ac Compare May 22, 2026 22:15

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fcoury-oai force-pushed the fcoury/next-suggestion-core branch 2 times, most recently from 87aa4e1 to d10d107 Compare May 22, 2026 22:57

feat(next-prompt): add suggestion engine

a0d7b8e

fcoury-oai force-pushed the fcoury/next-suggestion-core branch from d10d107 to a0d7b8e Compare May 22, 2026 23:01

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fix(next-prompt): avoid hidden usage misattribution

2da3ea1

chatgpt-codex-connector Bot reviewed May 22, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fix(next-prompt): attribute hidden usage to real turn

1c5aff3

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fix(next-prompt): avoid persisting hidden usage

374560d

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

fix(next-prompt): keep hidden usage out of context state

3a7434c

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

fix(next-prompt): keep hidden usage live-only

e07878e

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

Comment thread codex-rs/core/src/next_prompt_suggestion.rs Outdated

test(next-prompt): tolerate existing token snapshot

06405d3

fix(next-prompt): suppress unbounded hidden samples

4711e33

chatgpt-codex-connector Bot reviewed May 23, 2026

View reviewed changes

Comment thread codex-rs/core/src/context/contextual_user_message.rs Outdated

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

Comment thread codex-rs/core/src/next_prompt_suggestion.rs

fix(next-prompt): require stable suggestion history

e89c88d

github-actions Bot mentioned this pull request May 23, 2026

📊 AI CLI 工具社区动态日报 2026-05-23 ivanweng2077/big_model_radar#77

Open

Conversation

fcoury-oai commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What changed

Testing

Stack

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fcoury commented May 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

fcoury-oai commented May 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented May 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fcoury-oai commented May 23, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

fcoury-oai commented May 22, 2026 •

edited

Loading