Skip to content

feat(app-server): add next prompt suggestion RPC [2 of 3]#24127

Open
fcoury-oai wants to merge 2 commits into
fcoury/next-suggestion-corefrom
fcoury/next-suggestion-api
Open

feat(app-server): add next prompt suggestion RPC [2 of 3]#24127
fcoury-oai wants to merge 2 commits into
fcoury/next-suggestion-corefrom
fcoury/next-suggestion-api

Conversation

@fcoury-oai
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai commented May 22, 2026

Why

Clients need an explicit v2 API for requesting a next-prompt suggestion from an existing thread. This layer exposes that API on top of the core engine without adding the TUI presentation behavior.

What changed

  • Add thread/suggestNextPrompt v2 request/response types and generated JSON/TypeScript schema fixtures.
  • Route the new request through the app-server message processor and turn processor.
  • Sample suggestions from loaded thread history with cancellation support and no tool exposure.
  • Add focused app-server coverage for loaded-history sampling and in-flight cancellation.
  • Document the new method in the app-server README.

Testing

  • cargo test -p codex-app-server-protocol
  • cargo test -p codex-app-server thread_suggest_next_prompt
  • CARGO_TARGET_DIR=/private/tmp/codex-next-suggestion-stack-target ./tools/argument-comment-lint/run.py -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-tui

Generated/schema churn: yes, app-server v2 JSON and TypeScript schema fixtures are updated in this PR.

Stack

  1. #24126 next-prompt suggestion engine
  2. feat(app-server): add next prompt suggestion RPC [2 of 3] #24127 next-prompt app-server RPC (this PR)
  3. #23976 next-prompt TUI

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebf3205853

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/turn_processor.rs Outdated
Comment thread codex-rs/app-server-protocol/src/protocol/common.rs
Comment thread codex-rs/app-server/src/request_processors/turn_processor.rs
@fcoury-oai fcoury-oai changed the title feat(app-server): add next prompt suggestion RPC feat(app-server): add next prompt suggestion RPC [2 of 3] May 22, 2026
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from b059995 to 67e04fa Compare May 22, 2026 19:25
@fcoury-oai fcoury-oai requested a review from a team as a code owner May 22, 2026 19:25
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from ebf3205 to ea98223 Compare May 22, 2026 19:25
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 67e04fa to 5ea7930 Compare May 22, 2026 20:16
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from ea98223 to 4c9c125 Compare May 22, 2026 20:16
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 5ea7930 to 6bde0ac Compare May 22, 2026 22:15
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from 4c9c125 to ed2c40a Compare May 22, 2026 22:15
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 6bde0ac to 87aa4e1 Compare May 22, 2026 22:51
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from ed2c40a to 02683d5 Compare May 22, 2026 22:51
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from 87aa4e1 to d10d107 Compare May 22, 2026 22:57
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from 02683d5 to 774f228 Compare May 22, 2026 22:57
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-core branch from d10d107 to a0d7b8e Compare May 22, 2026 23:01
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch 2 times, most recently from 14760db to 072c55c Compare May 23, 2026 02:17
@fcoury-oai fcoury-oai force-pushed the fcoury/next-suggestion-api branch from b003831 to 415c590 Compare May 23, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant