feat(app-server): add next prompt suggestion RPC [2 of 3]#24127
Open
fcoury-oai wants to merge 2 commits into
Open
feat(app-server): add next prompt suggestion RPC [2 of 3]#24127fcoury-oai wants to merge 2 commits into
fcoury-oai wants to merge 2 commits into
Conversation
This was referenced May 22, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebf3205853
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b059995 to
67e04fa
Compare
ebf3205 to
ea98223
Compare
67e04fa to
5ea7930
Compare
ea98223 to
4c9c125
Compare
5ea7930 to
6bde0ac
Compare
4c9c125 to
ed2c40a
Compare
6bde0ac to
87aa4e1
Compare
ed2c40a to
02683d5
Compare
87aa4e1 to
d10d107
Compare
02683d5 to
774f228
Compare
d10d107 to
a0d7b8e
Compare
14760db to
072c55c
Compare
b003831 to
415c590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clients need an explicit v2 API for requesting a next-prompt suggestion from an existing thread. This layer exposes that API on top of the core engine without adding the TUI presentation behavior.
What changed
thread/suggestNextPromptv2 request/response types and generated JSON/TypeScript schema fixtures.Testing
cargo test -p codex-app-server-protocolcargo test -p codex-app-server thread_suggest_next_promptCARGO_TARGET_DIR=/private/tmp/codex-next-suggestion-stack-target ./tools/argument-comment-lint/run.py -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-tuiGenerated/schema churn: yes, app-server v2 JSON and TypeScript schema fixtures are updated in this PR.
Stack