Skip to content

chore(authz): adopt typed Warden relation contract from providers #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobbescodes wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −6
Open

chore(authz): adopt typed Warden relation contract from providers #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"@graphile/pg-aggregates": "^0.2.0-rc.1",
"@graphile/simplify-inflection": "^8.0.0-rc.2",
"@graphql-yoga/plugin-disable-introspection": "^2.19.0",
"@omnidotdev/providers": "github:omnidotdev/providers#ddc7829",
"@omnidotdev/providers": "github:omnidotdev/providers#1d1c21d",
"@omnidotdev/search": "github:omnidotdev/search",
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/auto-instrumentations-node": "^0.68.0",
Expand Down
8 changes: 5 additions & 3 deletions src/lib/authz/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import type {
PermissionCheck,
PermissionCheckResult,
TupleSyncResult,
WardenRelation,
WardenResourceType,
} from "@omnidotdev/providers";

/** @knipignore Used by scripts */
Expand Down Expand Up @@ -40,11 +42,11 @@ export function isTransactionalSyncMode(): boolean {
*
* @param accessToken - JWT access token (kept for API compatibility, auth handled by provider config)
*/
export async function checkPermission(
export async function checkPermission<T extends WardenResourceType>(
userId: string,
resourceType: string,
resourceType: T,
resourceId: string,
permission: string,
permission: WardenRelation<T>,
_accessToken: string,
requestCache?: Map<string, boolean>,
): Promise<boolean> {
Expand Down
Loading