chore(authz): adopt typed Warden relation contract from providers#47
Open
hobbescodes wants to merge 1 commit into
Open
chore(authz): adopt typed Warden relation contract from providers#47hobbescodes wants to merge 1 commit into
hobbescodes wants to merge 1 commit into
Conversation
Make the lib/authz checkPermission wrapper generic over the resource type so permission is constrained to the relations Warden defines for it, matching the new @omnidotdev/providers signature. All existing call sites already use valid relations, so this adds type safety with no behavior change. Bumps providers to the build that ships the contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task link: N/A
Adopt the typed Warden relation contract from
@omnidotdev/providers. Thelib/authzcheckPermission wrapper is now generic over the resource type, sopermissionis constrained to the relations Warden defines for that type. All existing call sites already use valid relations, so this adds type safety with no behavior change.Important
Depends on omnidotdev/providers#6. The
@omnidotdev/providerspin points at the feature-branch commit1d1c21d; re-pin it to the merge commit once omnidotdev/providers#6 merges, before merging this.Test Steps
bunx tsc --noEmitclean,bunx biome checkclean,bunx knipclean.