Skip to content

fix: Handle window closes correctly in reducestreamer #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BulkBeing merged 5 commits into from
Mar 10, 2026

remove debug log statements

698bda3
Select commit
Loading
Failed to load commit list.
Merged

fix: Handle window closes correctly in reducestreamer #331

remove debug log statements
698bda3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2026 in 0s

94.10% (-0.11%) compared to 4d33841

View this Pull Request on Codecov

94.10% (-0.11%) compared to 4d33841

Details

Codecov Report

❌ Patch coverage is 75.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.10%. Comparing base (4d33841) to head (698bda3).

Files with missing lines Patch % Lines
...numaflow/reducestreamer/servicer/async_servicer.py 79.41% 2 Missing and 5 partials ⚠️
...numaflow/pynumaflow/reducestreamer/async_server.py 66.66% 3 Missing ⚠️
...pynumaflow/reducestreamer/servicer/task_manager.py 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   94.20%   94.10%   -0.11%     
==========================================
  Files          66       66              
  Lines        3091     3137      +46     
  Branches      162      168       +6     
==========================================
+ Hits         2912     2952      +40     
- Misses        149      151       +2     
- Partials       30       34       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov