Skip to content

fix: show correct install size for native packages #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 11, 2026
Merged

fix: show correct install size for native packages #1357

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38718a6
fix: show correct install size for native packages
gameroman Feb 10, 2026
61c8d5d
[autofix.ci] apply automated fixes
autofix-ci[bot] Feb 10, 2026
71dfff5
fix: address review
gameroman Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,8 @@ const likeAction = async () => {
}
}

const dependencyCount = getDependencyCount(displayVersion.value)

Comment thread
gameroman marked this conversation as resolved.
Outdated
const numberFormatter = useNumberFormatter()
const compactNumberFormatter = useCompactNumberFormatter()
const bytesFormatter = useBytesFormatter()
Expand Down Expand Up @@ -841,12 +843,10 @@ onKeyStroke(
<dd class="font-mono text-sm text-fg flex items-center justify-start gap-2">
<span class="flex items-center gap-1">
<!-- Direct deps (muted) -->
<span class="text-fg-muted">{{
numberFormatter.format(getDependencyCount(displayVersion))
}}</span>
<span class="text-fg-muted">{{ numberFormatter.format(dependencyCount) }}</span>

<!-- Separator and total transitive deps -->
<template v-if="getDependencyCount(displayVersion) !== totalDepsCount">
<template v-if="dependencyCount > 0 && dependencyCount !== totalDepsCount">
<span class="text-fg-subtle">/</span>

<ClientOnly>
Expand All @@ -872,7 +872,7 @@ onKeyStroke(
</ClientOnly>
</template>
</span>
<ButtonGroup v-if="getDependencyCount(displayVersion) > 0">
<ButtonGroup v-if="dependencyCount > 0">
<LinkBase
variant="button-secondary"
size="small"
Expand Down Expand Up @@ -918,7 +918,7 @@ onKeyStroke(
</span>

<!-- Separator and install size -->
<template v-if="getDependencyCount(displayVersion) > 0">
<template v-if="displayVersion?.dist.unpackedSize !== installSize?.totalSize">
Comment thread
gameroman marked this conversation as resolved.
Outdated
<span class="text-fg-subtle mx-1">/</span>

<span
Expand Down
Loading