Skip to content

Conversation

@gameroman
Copy link
Contributor

Before

image image

After

image image

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 11:33pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 11:33pm
npmx-lunaria Ignored Ignored Feb 10, 2026 11:33pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

This change adds a computed dependencyCount = computed(() => getDependencyCount(displayVersion.value)) and replaces multiple direct calls to getDependencyCount(displayVersion) in the package page with this single source of truth. Conditional rendering for direct deps, transitive deps, and the ButtonGroup now uses dependencyCount. The install-size secondary info condition is changed to check displayVersion?.dist.unpackedSize !== installSize?.totalSize instead of relying on the dependency count.

Possibly related PRs

Suggested reviewers

  • danielroe
  • whitep4nth3r
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly relates to the changeset, showing before/after screenshots that demonstrate the UI modifications to the package metadata display.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 20.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@gameroman
Copy link
Contributor Author

is github serious lol? why does it trim titles at the end of the title correctly automatically but not at the start

@gameroman gameroman changed the title fix: show correct install size for native packages fix: show correct install size for native packages Feb 10, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

@danielroe danielroe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit bb234a1 Feb 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants