Skip to content

doc: test and test-only targets do not run linter anymore #62120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xstoudi wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −7
Open

doc: test and test-only targets do not run linter anymore #62120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions BUILDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,9 @@ If you are running tests before submitting a pull request, use:
```bash
make -j4 test
```
`make -j4 test` does a full check on the codebase, including documentation tests.

`make -j4 test` does a full check on the codebase, including running linters and
documentation tests.

To run the linter without running tests, use
`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
To run the linter, use `make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.

To fix auto fixable JavaScript linting errors, use `make lint-js-fix`.

Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ coverage-run-js: ## Run JavaScript tests with coverage.

.PHONY: test
# This does not run tests of third-party libraries inside deps.
test: all ## Run default tests, linters, and build docs.
test: all ## Run default tests and build docs.
$(MAKE) -s tooltest
$(MAKE) -s test-doc
$(MAKE) -s build-addons
Expand All @@ -350,7 +350,7 @@ test: all ## Run default tests, linters, and build docs.
$(MAKE) -s jstest

.PHONY: test-only
test-only: all ## Run default tests, without linters or building the docs.
test-only: all ## Run default tests without building the docs.
$(MAKE) build-addons
$(MAKE) build-js-native-api-tests
$(MAKE) build-node-api-tests
Expand Down
Loading