Skip to content

doc: test and test-only targets do not run linter anymore#62120

Open
Xstoudi wants to merge 1 commit intonodejs:mainfrom
Xstoudi:doc/test-do-not-lint
Open

doc: test and test-only targets do not run linter anymore#62120
Xstoudi wants to merge 1 commit intonodejs:mainfrom
Xstoudi:doc/test-do-not-lint

Conversation

@Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Mar 5, 2026

make test and make test-only targets no longer runs linters. This commit updates the inline comments and building doc to reflect reality.

Fixes: #58606

`make test` and `make test-only` targets no longer runs linters.
This commit updates the inline comments and building doc to reflect reality.

Fixes: nodejs#58606
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. labels Mar 5, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (15bdf38) to head (53b3e54).
⚠️ Report is 477 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62120      +/-   ##
==========================================
+ Coverage   88.53%   89.59%   +1.06%     
==========================================
  Files         703      674      -29     
  Lines      208598   205261    -3337     
  Branches    40227    39381     -846     
==========================================
- Hits       184674   183913     -761     
+ Misses      15951    13549    -2402     
+ Partials     7973     7799     -174     

see 249 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: lint under make test?

2 participants