quic: copy options buffer instead of detaching #61403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
legendecas
added
the
quic
Renegade334
reviewed
Jan 16, 2026
Member
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
Was going to suggest a similar approach.
The commit message should probably reflect that this applies to all buffer-based quic options, not just SessionOptions#certs.
legendecas
force-pushed
the
quic-certs
branch
2 times, most recently
from
da77e1e to
b8f90b8
Compare
legendecas
changed the title
legendecas
changed the title
The certs could be allocated in a pooled buffer, like `Buffer.from`, and `Buffer.allocUnsafe` (used by `fs.readFileSync`, etc).
legendecas
force-pushed
the
quic-certs
branch
from
b8f90b8 to
7a9130c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61403 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 704 704
Lines 208797 208806 +9
Branches 40316 40308 -8
==========================================
- Hits 184857 184834 -23
- Misses 15923 15971 +48
+ Partials 8017 8001 -16
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Jan 17, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
avivkeller
added
the
author ready
addaleax
approved these changes
Jan 21, 2026
| auto length = view->ByteLength(); | ||
| auto offset = view->ByteOffset(); | ||
| auto dest = ArrayBuffer::NewBackingStore( | ||
| isolate, length, v8::BackingStoreInitializationMode::kUninitialized); |
Member
There was a problem hiding this comment.
Would be nice if we could handle allocation failures in these calls too
Member
Author
There was a problem hiding this comment.
You are right. I think we can use BackingStoreOnFailureMode to gracefully handle the failure. Given that there are many ArrayBuffer::NewBackingStore call sites in the codebase, I could file a follow-up to bulk update.
legendecas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61403 ✔ Done loading data for nodejs/node/pull/61403 ----------------------------------- PR info ------------------------------------ Title quic: copy options buffer instead of detaching (#61403) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:quic-certs -> nodejs:main Labels c++, lib / src, author ready, needs-ci, quic Commits 1 - quic: copy options.certs buffer instead of detaching Committers 1 - Chengzhong Wu <cwu631@bloomberg.net> PR-URL: https://github.com/nodejs/node/pull/61403 Refs: https://github.com/nodejs/node/pull/61372 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61403 Refs: https://github.com/nodejs/node/pull/61372 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 16 Jan 2026 20:26:08 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61403#pullrequestreview-3674325947 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/61403#pullrequestreview-3687646808 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-19T23:08:55Z: https://ci.nodejs.org/job/node-test-pull-request/70898/ - Querying data for job/node-test-pull-request/70898/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... remote: Internal Server Error fatal: unable to access 'https://github.com/nodejs/node/': The requested URL returned error: 500https://github.com/nodejs/node/actions/runs/21252560285 |
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 41c6256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
certscould be allocated in a pooled buffer, likeBuffer.from, andBuffer.allocUnsafe(used byfs.readFileSync, etc).Refs: #61372