src: throw RangeError on failed ArrayBuffer BackingStore allocation #61480
+53
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates
ERR_MEMORY_ALLOCATION_FAILEDto be a RangeError,aligning with V8's OutOfMemory error type and ECMAScript's OutOfMemory
error type.
There are still many call sites in crypto, tls and quic need to be reviewed
to properly handle the failed ArrayBuffer BackingStore allocation. This
PR updates call sites not in these modules.
Refs:
node/deps/v8/src/builtins/builtins-typed-array.cc
Line 584 in c755b01
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Refs: #61403 (comment)