Add Date::New overload for a std::chrono::system_clock::time_point#1705
Open
cacharle wants to merge 2 commits intonodejs:mainfrom
Open
Add Date::New overload for a std::chrono::system_clock::time_point#1705cacharle wants to merge 2 commits intonodejs:mainfrom
cacharle wants to merge 2 commits intonodejs:mainfrom
Conversation
Author
|
Not too sure how to add a unit test for this since it seems they're being done in JS |
Member
|
Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/date.cc and https://github.com/nodejs/node-addon-api/blob/main/test/date.js? Thank you! |
Author
|
Added some basic unit test, |
legendecas
reviewed
Feb 26, 2026
| Object InitDate(Env env) { | ||
| Object exports = Object::New(env); | ||
| exports["CreateDate"] = Function::New(env, CreateDate); | ||
| exports["CreateDateFromTimePoint"] = Function::New(env, CreateDate); |
Member
There was a problem hiding this comment.
Suggested change
| exports["CreateDateFromTimePoint"] = Function::New(env, CreateDate); | |
| exports["CreateDateFromTimePoint"] = Function::New(env, CreateDateFromTimePoint); |
| OperatorValue | ||
| } = binding.date; | ||
| assert.deepStrictEqual(CreateDate(0), new Date(0)); | ||
| assert.deepStrictEqual(CreateDateFromTimePoint(), new Date(0)); |
Member
There was a problem hiding this comment.
CreateDateFromTimePoint needs to be destructed in line 8 above.
KevinEady
requested changes
Feb 26, 2026
Contributor
KevinEady
left a comment
KevinEady
left a comment
There was a problem hiding this comment.
Guards for c++11 can be removed.
Comment on lines
+1
to
+4
| #if __cplusplus >= 201103L | ||
| #include <chrono> | ||
| #endif | ||
|
|
Contributor
There was a problem hiding this comment.
Similar to https://github.com/nodejs/node-addon-api/pull/1706/changes#r2861661700, this guard can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1704