Add String::New overload for string_view

[cacharle]

Fixes #1703

[cacharle]

I added the New overload for Symbol aswell. I looked at other functions that take const char* but there is way too many of them and I don't want to unnecessarily bloat the code / break something so let me know if there is other place which could benefit from this overload

[legendecas]

Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/name.cc? Thank you!

[legendecas]

I added the New overload for Symbol aswell. I looked at other functions that take const char* but there is way too many of them and I don't want to unnecessarily bloat the code / break something so let me know if there is other place which could benefit from this overload

Sounds good! we can start with these two sites.

[cacharle]

Same as #1705, the test take too long to compile, not sure how to run them

[legendecas]

@cacharle I added a doc about building with ninja to speed up local builds: #1709

[legendecas]

This seems to be the reason that the test failed.

Suggested change

	exports["CreateSymbolFromStringView"] = Function::New(env, CreateSymbolFromStringView);
	exports["createSymbolFromStringView"] = Function::New(env, CreateSymbolFromStringView);

[KevinEady]

Guards for c++17 can be removed.

[KevinEady]

We discussed in the Node API meeting on 20 Feb that this guard can be removed.
std::string_view was added in c++17, which is a minimum requirement starting with Node.js v20 (ref). Building addons with node-addon-api have the same build requirements as those of Node.js, so a minimum of c++17.