Skip to content

add fallback title setter to handle case where filename is absent in path #3079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Mar 19, 2026
Merged

add fallback title setter to handle case where filename is absent in path #3079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/main-Ke6Ju54g.chunk.css → css/main-Bg3U4zXh.chunk.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion css/viewer-main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/* extracted by css-entry-points-plugin */
@import './main-Ke6Ju54g.chunk.css';
@import './main-Bg3U4zXh.chunk.css';
@import './previewUtils-DsspQ6dL.chunk.css';
8 changes: 4 additions & 4 deletions js/viewer-main.mjs
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/viewer-main.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions src/views/Viewer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,15 @@ export default defineComponent({
this.handlerId = handler.id

this.currentFile = new File(fileInfo, mime, handler.component)

// if openFile() couldn’t derive a name from the path (e.g. "/" for single-file shares),
// fall back to the displayname to set the title
const title = document.getElementsByTagName('head')[0].getElementsByTagName('title')[0]
if (title && !title.dataset.old && this.currentFile.displayname) {
title.dataset.old = document.title
this.updateTitle(this.currentFile.displayname)
}

this.comparisonFile = null
this.updatePreviousNext()

Expand Down
Loading