add fallback title setter to handle case where filename is absent in path#3079
Open
emberfiend wants to merge 1 commit intomasterfrom
Open
add fallback title setter to handle case where filename is absent in path#3079emberfiend wants to merge 1 commit intomasterfrom
emberfiend wants to merge 1 commit intomasterfrom
Conversation
emberfiend
force-pushed
the
feat/single-file-share-title
branch
from
4c76fb2 to
5ec87ce
Compare
juliusknorr
approved these changes
Mar 11, 2026
skjnldsv
approved these changes
Mar 12, 2026
Member
|
Needs a rebase/recompile, i guess cypress failures are unrelated |
…is absent in path Signed-off-by: Andrew Backhouse <andrew.backhouse@nextcloud.com>
emberfiend
force-pushed
the
feat/single-file-share-title
branch
from
5ec87ce to
8fbc16a
Compare
Author
|
@juliusknorr rebased & recompiled, but I don't have the rights to skip cypress here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add fallback title setter to handle case where filename is absent in path
closes nextcloud/richdocuments#2619