refactor: Soft remove Emitter from IRootFolder interface#61539
Merged
Conversation
Move this to the private implementation in OC, so that using IRootFolder in apps doesn't require dummy stubs. This will create a new psalm warnings for users of this method but considering that this is deprecated for a long time and that it still works at runtime, this shouldn't cause any issue. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
added
technical debt
CarlSchwan
requested review from
Altahrim and
icewind1991
and removed request for
a team
CarlSchwan
added
the
♻️ refactor
Member
Author
CarlSchwan
removed
the
pending documentation
susnux
approved these changes
Jun 23, 2026
come-nc
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move this to the private implementation in OC, so that using IRootFolder in apps doesn't require dummy stubs.
This will create a new psalm warnings for users of this method but considering that this is deprecated for a long time and that it still works at runtime, this shouldn't cause any issue.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)