refactor: Remove long deprecated IServerContainer usages#12987
refactor: Remove long deprecated IServerContainer usages#12987CarlSchwan wants to merge 1 commit into
Conversation
Signed-off-by: Carl Schwan <carlschwan@kde.org>
d623448 to
325e38e
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR refactors the application and test suite to use the 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| return $userContainer->getUserFolder($uid); | ||
| /** @var IRootFolder $rootFolder */ | ||
| $rootFolder = $c->get(IRootFolder::class); |
There was a problem hiding this comment.
interface IRootFolder extends Folder, Emitter
trading one tech debt with another 🙈
I don't think we need the emitter. Adjust the Psalm config to ignore the missing dependency
No description provided.