Skip to content

added patch for resolving 'overall PWA' installations so that they wi… #58557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crowetic wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

added patch for resolving 'overall PWA' installations so that they wi… #58557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/theming/lib/ThemingDefaults.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,15 @@ public function replaceImagePath($app, $image) {
$route = $this->urlGenerator->linkToRoute('theming.Icon.getTouchIcon', ['app' => $app]);
}
if ($image === 'manifest.json') {
// Force instance branding for the installable shell manifest.
// `core` and `settings` ship a static manifest.json, but for PWAs we want
// the dynamic theming manifest so the app name/icon follow instance theming.
if ($app === 'core' || $app === 'settings') {
$route = $this->urlGenerator->linkToRoute('theming.Theming.getManifest', ['app' => 'core']);
}
if ($route !== false) {
return $route . '?v=' . $this->util->getCacheBuster();
}
try {
$appPath = $this->appManager->getAppPath($app);
if (file_exists($appPath . '/img/manifest.json')) {
Expand Down