added patch for resolving 'overall PWA' installations so that they wi…#58557
Open
crowetic wants to merge 1 commit intonextcloud:masterfrom
Open
added patch for resolving 'overall PWA' installations so that they wi…#58557crowetic wants to merge 1 commit intonextcloud:masterfrom
crowetic wants to merge 1 commit intonextcloud:masterfrom
Conversation
…ll follow theme. Signed-off-by: crowetic <jason@crowetic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ll follow theme.
Resolves - #56135
Summary - This is a small modification to the way the manifest.json is handled to ensure that themed instances when installing an 'overall PWA' remains themed as opposed to falling back to default 'Nextcloud' and Nextcloud logo.
Users wishing to setup an 'overall pwa' can do so from any 'settings' path (once this patch has been added to their code.)
(Tested on NC33 installed server running installation from nextcloud/vm and updated to 33 via updater in the vm scripts. However, in theory any installation should work just fine. )