Format AppNavigationForm.vue (refs #3099)#3188
Conversation
|
could you please sign off your commit?
Ideally please use conventional commits as well, e.g. |
409aff1 to
b35c690
Compare
susnux
left a comment
There was a problem hiding this comment.
I think this causes invalid HTML.
Because now this results in div within a ul, which is invalid and will cause accessibility issues.
e90907b to
fed9346
Compare
fed9346 to
1ef61e8
Compare
1ef61e8 to
0f232a6
Compare
|
Update: isn’t exported by @nextcloud/dialogs v6.4.2 (build failed). I replaced it with DialogBuilder + DialogSeverity to keep the same confirmation UX without the invalid HTML wrapper. |
Signed-off-by: don9x2E <revan@kakao.com>
0f232a6 to
5891e3a
Compare
Maybe but we can also easily update to dialogs v7 |
|
/backport to stable5.2 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Format AppNavigationForm.vue to satisfy eslint/prettier
resolves Delete form only possible by super weird, click order #3099