Follow up IME option creation and delete dialog timing fixes#3185
Conversation
Chartman123
left a comment
There was a problem hiding this comment.
Looks good, just some small comments :)
|
Thanks for the review!
|
cf90b95 to
972f2ae
Compare
bb59d34 to
34b3ea4
Compare
|
Addressed: the add button is now disabled when input is empty (kept enabled for non-empty input, only disabled during active IME composition). Re debounce: we still need it for updating existing options (typing in non-local options triggers PATCH). For new option creation, it only happens via Enter or the add button. |
|
@don9x2E the button is still not working as expected: now it stays disabled even if there is some input. It looks like your canCreateLocalAnswer is not executed upon input. |
|
@don9x2E still the same... there were some issues with reactivity left. I tried to fix it with Copilot. Please have a look at my commit, if it's still working correctly during IME input. non-IME input is working now. Before we merge it, please rebase your code on current main and also squash all commits into a single one. |
I guess so |
04479c9 to
e6dd00a
Compare
|
@don9x2E you've lost my changes |
e6dd00a to
c39eb6f
Compare
|
Sorry for the missing. Re-applied the reviewer changes and force-pushed the squashed commit (c39eb6f). |
|
ok, now just the lint error and then we're good to go :) |
Signed-off-by: don9x2E <revan@kakao.com>
c39eb6f to
e92a705
Compare
|
/backport to stable5.2 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Follow-up fixes after #3183 to address remaining real-world Korean IME issues and related UX regressions.
Enterafter composition end, or+button clickWhy this follow-up is needed
The initial IME patch improved composition handling, but in actual Korean IME use there were still edge cases where input-driven side effects could trigger option creation timing unexpectedly.
Switching local-row creation to explicit intent removes those composition timing race paths while preserving normal editing for existing options.
Trade-off
Auto-create-on-input for the local empty row is intentionally disabled for now to prioritize deterministic IME-safe behavior.
Validation