Skip to content

feat: client integration with server features #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camilasan wants to merge 23 commits into
base: master
Choose a base branch
from
Open

feat: client integration with server features #9403

camilasan wants to merge 23 commits into from
+1,094 −119

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Jan 31, 2026 •
edited
Loading

Implements nextcloud/files-clients#86

  • screenshots

tbd

  • to do

    • get designer's input
    • filter by mime type
      • there are some glitches
    • test with files explorer/finder context menu
    • do not show file actions when there are none

@camilasan camilasan closed this Jan 31, 2026
@camilasan camilasan reopened this Jan 31, 2026
@camilasan camilasan mentioned this pull request Jan 31, 2026
Closed
8 tasks
@camilasan camilasan force-pushed the feature/integration branch 4 times, most recently from f4a096c to c2b2235 Compare January 31, 2026 20:56
@camilasan
feat(socketapii): add file actions option to list of options for files.
aae3488 
- declarativeui: add endpoints model.
- capabilities: fetch endpoints in capabilities.
- display endpoints in an application window.
- list file actions in context menu.
- remove EndpointModel from DeclarativeUi class.
- list declarative ui and file actions in the tray activitiy.
- add icon and filter to endpoint model and UI.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): style file actions window.
953197c 
- display response from request from file actions.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): improve the looks of the file actions Window.
b66b294 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui/fileactions): file actions context menu.
97cc1cc 
- add helper function to match string to SimpleApiJob::Verb.
- filter and display file actions based on the file mimetype.
- adjust logic to get context menu by mimeType.
- create function to set file id and mime type.
- rename Endpoint to FileActions.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): add logging category to FileActionsModel.
271daa4 
- improve error handling.
- display a different icon for each mimetype.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui/fileactions): return default icon when server does…
4d14efb 
…n't have one.

- improve file actions window UI.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui/fileactions): parse response with declarative UI el…
99efd45 
…ements like url.

- add opacity mask and more spacing.
- implement hover for the file action buttons.
- fix logic to display error/success messages.
- improve text for error/success messages.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
refactor(declarativeui): remove unused DeclarativeUi class.
5f8becf 
The declarative ui in fact will be returned in the response from file actions.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui): files license.
5274c58 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/integration branch from c2b2235 to 1e44251 Compare January 31, 2026 21:13
@camilasan
refactor(declarativeui): remove Declarative UI menu item.
82f0e97 
- use reference type in for loop.
- fix spaces and sizes in the file actions window.
- remove missing file from resources.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(capabilities): update capabilities with new json key + adjust mim…
c6bca1d 
…etype check.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui): use EnforcedPlainTextLabel instead of Label.
de99e9e 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(capabilities): an empty mimetype_filters means the action is avai…
9ebde2d 
…lable to all mimetypes.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui/fileactions): handle the new params format.
d1f63ae 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
style(integration): rename from declarativeui to integration.
039efde 
- remove DeclarativeUi files.
- add return default value in switch.
- add const.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/integration branch from 1e44251 to 039efde Compare January 31, 2026 21:19
@camilasan
fix(integratio): return true if there isn't an empty client_integrati…
d77eb58 
…on map.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(integration): do not list file actions if the server doesn't sup…
0360824 
…port it.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
style(tray): modernize ActivityListModel::data.
69a99ba 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan added this to the 33.0.0 milestone Feb 2, 2026
@camilasan camilasan marked this pull request as ready for review February 2, 2026 19:02
@camilasan camilasan requested a review from Aiiaiiio as a code owner February 2, 2026 19:02
@mgallien
Copy link
Collaborator

mgallien commented Feb 3, 2026

reviewing it

nilsding
nilsding requested changes Feb 3, 2026
View reviewed changes
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Some unit tests for at least the FileActionsModel and (if possible) Capabilities::fileActionsByMimeType would be really nice to have as well.

@camilasan
fix(integration): use ActivityData function to retrieve server icon.
33bae82 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/integration branch 2 times, most recently from e93a493 to d6a05da Compare February 3, 2026 11:56
@camilasan
refactor(tray): modernize Activity::relativeServerFileTypeIconPath.
2f11157 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(integration): align icons and make sure they all have the same s…
9152235 
…ize.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(integration): remove unused files and variables.
6c1fce4 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(integration): missing reference on non-trivial type.
5a24e0e 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/integration branch from d6a05da to 5a24e0e Compare February 3, 2026 12:19
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9403.zip

Digest: sha256:22fa2629625772498cc6034d0e44ccefd791d94b1ee855cbb2e4385c2951855a

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
15.7% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
169 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nilsding nilsding nilsding requested changes

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

💻 Desktop Clients team
Status: 🏗️ In progress

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@camilasan @mgallien @nilsding