Skip to content

WIP: declarative UI. #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camilasan wants to merge 34 commits into from
Closed

WIP: declarative UI. #8401

camilasan wants to merge 34 commits into from

Conversation

@camilasan
Copy link
Member

@camilasan camilasan commented Jun 25, 2025 •
edited
Loading

Implements nextcloud/files-clients#86

dialog

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 25, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)
55 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding
Copy link
Member

nilsding commented Jul 1, 2025

looking good so far

one nit for the current app-menu-submenu-WIP: Apps that provide custom actions should be indicated as such -- this could be done by e.g. appending … at the end of the name, or adding another arrow button similar to how it's done in the accounts drop down

@camilasan camilasan force-pushed the feature/declarative-ui branch from 8f783b2 to 330facf Compare September 3, 2025 19:31
@Rello Rello moved this to 🏗️ In progress in 💻 Desktop Clients team Sep 4, 2025
@camilasan camilasan changed the title wip: declarative UI. feat: declarative UI. Sep 8, 2025
@camilasan camilasan force-pushed the feature/declarative-ui branch from 533a29d to 31f81d6 Compare September 18, 2025 00:10
@camilasan camilasan force-pushed the feature/declarative-ui branch 7 times, most recently from fb77cbc to 4a95c2c Compare October 1, 2025 17:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
108 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Rello Rello moved this from 🏗️ In progress to 📄 To do in 💻 Desktop Clients team Nov 3, 2025
@camilasan camilasan changed the title feat: declarative UI. WIP: declarative UI. Dec 4, 2025
@Rello Rello moved this from 📄 To do to 🏗️ In progress in 💻 Desktop Clients team Dec 12, 2025
@camilasan
feat(socketapi): add file actions option to list of options for files.
46df1cf 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): add basic class to retrieve json from server.
a33ea24 
- add endpoints model.
- add class to manage endpoints and declarativeui display.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): fetch delcarativeui endpoints in capabilities.
f37e24d 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): display application window with declarative ui.
5a64346 
- display endpoints in an application window.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): list declarative ui and file actions in context …
394f531 
…menu.

- remove EndpointModel from DeclarativeUi class.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): list declarative ui and file actions in the tray…
7f1127f 
… activitiy.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix(declarativeui): remove log messages.
b99f3ea 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): add icon and filter to endpoint model and UI.
5e429c2 
- add one action to the endpoints.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat: style file actions window.
12a628f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat: display response from request from file actions.
af8c1b2 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat(declarativeui): improve the looks of the file actions Window.
609be60 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat: add helper function to match string to SimpleApiJob::Verb.
a103167 
- use the file id in file actions requests.
- filter and display file actions based on the file mimetype.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: handle file action response.
ea23761 
- adjust logic to get context menu by mimeType.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
refactor: create function to set file id and mime type.
de2c088 
- remove unused functions.
- save string values in constexpr
- rename Endpoint to Fileactions.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat: add logging category to FileActionsModel.
7e23ef2 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
refactor: improve error handling.
633add2 
- change icon for file.
- display a different icon for each mimetype.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
feat: return default icon when server doesn't have one.
b85be63 
- improve file actions window UI.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: parse response with declarative UI elements like url.
a271e3e 
- add opacity mask and more spacing.
- Implement hover for the file action buttons.
- fix logic to display error/success messages.
- improve text for error/success messages.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
refactor: remove unused DeclarativeUi class.
538296c 
The declarative ui in fact will be returned in the response from file actions.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: files license.
ea43cd1 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
refactor: remove Declarative UI menu item.
fa0b1dd 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: use reference type in for loop.
e1c82df 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: spaces and sizes in the file actions window.
c1df938 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/declarative-ui branch from 4a95c2c to c1df938 Compare January 19, 2026 21:00
@camilasan
fix: remove missing file from resources.
f1caf41 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: update capabilities with new json key + adjust mimetype check.
3c3dd1f 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-8401.zip

Digest: sha256:9bdb8f9fe1f67bf777ce7595dc3cec09792ca51dbce9f0657c53868e89ee0086

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan added this to the 33.0.0 milestone Jan 21, 2026
@camilasan
fix: use EnforcedPlainTextLabel instead of Label.
1e4b1ef 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: an empty mimetype_filters means the action is available to all m…
3522e47 
…imetypes.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: handle the new params format.
4d054a6 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
style: rename from declarativeui to integration.
c61ea9b 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
style: remove DeclarativeUi files.
562ff8b 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
style: use file actions instead of declarative ui.
bd6786a 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan
fix: warnings reported.
04ee373 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan camilasan force-pushed the feature/declarative-ui branch from 2554ede to 04ee373 Compare January 31, 2026 10:30
@camilasan
Copy link
Member Author

camilasan commented Jan 31, 2026

closing this version in favor of #9403

@camilasan camilasan closed this Jan 31, 2026
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💻 Desktop Clients team Jan 31, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 31, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
21 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
96 New Code Smells (required ≤ 0)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aiiaiiio Aiiaiiio Awaiting requested review from Aiiaiiio Aiiaiiio will be requested when the pull request is marked ready for review Aiiaiiio is a code owner

@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 will be requested when the pull request is marked ready for review i2h3 is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien will be requested when the pull request is marked ready for review mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding will be requested when the pull request is marked ready for review nilsding is a code owner

Assignees

@camilasan camilasan

Labels

None yet

Projects

None yet

Milestone

33.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@camilasan @nilsding