Fix rustup-init fallback: wrap in ErrorActionPreference Continue - #320
Merged
Conversation
… --no-modify-path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try/finallywith$ErrorActionPreference = 'Continue'— the script default isStop, and rustup-init writes warnings to stderr (e.g. "It looks like you have an existing installation of Rust at:") which triggered an immediate throw underStop--no-modify-pathflag to avoid PATH conflicts with existing Chocolatey Rust installationRoot cause
Pipeline #35: choco install rustup.install failed (package not found on community feed), then rustup-init.exe fallback triggered but failed because rustup-init wrote a warning to stderr about the existing Rust installation. With
$ErrorActionPreference = Stopat the script level, the stderr warning was treated as a terminating error, throwing before rustup-init could complete.Validation
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.