Add cargo bin to PATH after rustup-init fallback - #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.cargo/bin, explicitly add that directory to PATH viaAdd-PrerequisitePathbeforeRefresh-PrerequisitePath--no-modify-pathflag (added in PR Fix rustup-init fallback: wrap in ErrorActionPreference Continue #320) prevents rustup-init from modifying PATH env vars, so the install directory was never on PATH whenRequire-PrerequisiteCommandchecked forrustupRoot cause
Pipeline #36: choco install rustup.install failed 3x (504 Gateway Timeout from Chocolatey community feed). The rustup-init.exe fallback ran but
rustupwas still not found on PATH because--no-modify-pathprevented the install directory from being added to PATH, andRefresh-PrerequisitePathonly refreshes from existing Machine+User PATH env vars.Validation
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.