Skip to content

🔒 [security fix] Unvalidated URL Scheme in Webhook Target #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmuench merged 1 commit into from
Feb 26, 2026
Merged

🔒 [security fix] Unvalidated URL Scheme in Webhook Target #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions _locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,19 @@
"optionsTestError": {
"message": "Error sending test webhook: ",
"description": "Error message for the test webhook."
}
,
},
"optionsErrorInvalidUrlScheme": {
"message": "Invalid URL scheme. Only http:// and https:// are allowed.",
"description": "Error message when a webhook URL has an invalid scheme."
},
"optionsErrorInvalidUrl": {
"message": "Invalid URL.",
"description": "Error message when a webhook URL is invalid."
},
"optionsErrorUrlRequired": {
"message": "URL is required.",
"description": "Error message when a webhook URL is missing."
},
"optionsAppearanceHeader": {
"message": "Appearance",
"description": "Header for the appearance section."
Expand Down
18 changes: 18 additions & 0 deletions utils/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,24 @@ async function sendWebhook(webhook, isTest = false) {

const url = webhook.url;

if (!url) {
throw new Error(browserAPI.i18n.getMessage("optionsErrorUrlRequired") || "URL is required.");
}

try {
const urlObj = new URL(url);
if (urlObj.protocol !== "http:" && urlObj.protocol !== "https:") {
const schemeError = new Error(browserAPI.i18n.getMessage("optionsErrorInvalidUrlScheme") || "Invalid URL scheme. Only http:// and https:// are allowed.");
schemeError.name = "SchemeError";
throw schemeError;
}
} catch (e) {
if (e.name === "SchemeError") {
throw e;
}
throw new Error(browserAPI.i18n.getMessage("optionsErrorInvalidUrl") || "Invalid URL.");
}

if (method === "POST") {
fetchOpts.body = JSON.stringify(payload);
} else if (method === "GET") {
Expand Down