Show the source branch on pushes matched by a wildcard rule#9570
Open
hneiva wants to merge 1 commit into
Open
Conversation
Repositories can match pushes through wildcard branch rules — the catch-all "*" or a prefix like "release/*". The specific branch that matched was previously discarded, so the UI had no way to show whether a push came from, say, release/v151.0 or release/v150.0. Record that branch on the Push when (and only when) it matches a wildcard rule; exact branch rules are implied by the repository and stay null. The branch is exposed through the push API and rendered as a badge next to the author in the push header. - model: add nullable Push.branch (migration 0053) - ingest: capture the matched branch for wildcard rules only - api: add branch to PushSerializer - ui: render a branch badge in PushHeader when present
Collaborator
|
@hneiva can you provide steps for how you tested this locally? I haven't been able to find any commits/repos that should have that badge. I've tried a few commits from the firefox-ios repo with your other PR #9566 applied but none of them have this tag. Example of one of them that I tried ingesting locally: mozilla-mobile/firefox-ios@e650f48 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repositories can match pushes through wildcard branch rules — the catch-all "" or a prefix like "release/". The specific branch that matched was previously discarded, so the UI had no way to show whether a push came from, say, release/v151.0 or release/v150.0.
Record that branch on the Push when (and only when) it matches a wildcard rule; exact branch rules are implied by the repository and stay null. The branch is exposed through the push API and rendered as a badge next to the author in the push header.
Example:
Note: badge should not appear on repos without wilcard branch configs