feat: Bug 1957113 Add release branches for firefox-ios#9566
Conversation
hneiva
changed the title
|
This will conflict with #9564 If possible I'd like to merge that other one first as it's somewhat time sensitive (hoping to have it ready for a contractor next week). |
hneiva
force-pushed
the
hneiva/ios-release-branches
branch
from
b784324 to
4c8ce05
Compare
|
updated the pk |
| "model": "model.repositorybranch", | ||
| "fields": { | ||
| "repository": 131, | ||
| "branch": "release/*" |
There was a problem hiding this comment.
Do you want all releases as one list of release pushes in Treeherder?
There was a problem hiding this comment.
Yes. For every new version of the app they create a new branch.
| "pk": 61, | ||
| "model": "model.repositorybranch", | ||
| "fields": { | ||
| "repository": 131, |
There was a problem hiding this comment.
This will change the current firefox-ios Treeherder view to only show pushes for release branches. Is this intended? If the purpose is a new view for pushes to release branches, https://github.com/mozilla/treeherder/blob/master/treeherder/model/fixtures/repository.json needs to have the firefox-ios repository added once more and reference from here.
There was a problem hiding this comment.
I was under the impression this would be added along with the current main ref (I even asked claude to verify this was the case, but I wasn't able to fully test it locally).
It should be ok, at least for now, for main + release/* branches to be shown in the same view.
There was a problem hiding this comment.
Yeah, it should make the view show both main and any pushes to releases/*. But that does mean that the project will no longer show a chronological list of pushes. This might surprise some iOS devs? Not necessarily an issue or anything, but worth making sure it's what they actually want / expect.
There was a problem hiding this comment.
I don't think the iOS devs will be using treeherder, right now it's only build jobs.
All in the same view would be ok imo, if there was some indicator of the branch?
hneiva
force-pushed
the
hneiva/ios-release-branches
branch
from
4c8ce05 to
c55bafc
Compare
4 participants
No description provided.