Bug 2032243: Use the confidence interval for the significance column#1056
Open
kala-moz wants to merge 3 commits into
Open
Bug 2032243: Use the confidence interval for the significance column#1056kala-moz wants to merge 3 commits into
kala-moz wants to merge 3 commits into
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The Sig column, its filter, its sort, and the expanded-row alert now all read from a single precomputed bootstrap (BCa) CI on the difference of medians, replacing the Mann-Whitney p-value's `interpretation` string as the source of truth.
kala-moz
force-pushed
the
use-CI-for-significance-col
branch
from
23a51da to
13259e7
Compare
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Contributor
Author
mannWhitney: lazy-precompute Sig CI to restore production-level load speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The significance column, its filter, its sort, and the expanded-row alert now all read from a single precomputed bootstrap (BCa) CI on the difference of medians, replacing the Mann-Whitney p-value's
interpretationstring as the source of truth.AddedMannWhitneyResultsItem.bootstrapCiand aprecomputeMannWhitneyCIhelper that the four data loaders (compare, over-time, subtests, subtests-over-time) call once per row. Doing it at load time keeps sort/filter/render at property-access speed.matchesFunctionandsortFunctionreadbootstrapCi. Sort is "significant first, then |medianDiff| desc" — written in ASC semantics souseTableSort's DESC swap produces that order. The cell render usesbootstrapCi?.significantto pick icon vs-renderExpandedRightreads the same precomputed CI (with an inline fallback for callers that mount the strategy without a loader).PValCliffsDeltaComp. The Δ-median alert already conveys CI-based significance, and showing the p-value contradicts the Sig column.tooltipSignificanceandtooltipStatusMannWhitneyto match the new definition (BCa CI excludes zero, not p-value < 0.05).Deploy Link
Browser time preview
Updates:
precomputeMannWhitneyCI. Their.thencallbacks are removed entirely; results flow straight through. Unused imports (precomputeMannWhitneyCI,MannWhitneyResultsItem) dropped from each file.