Bug 2024208: Add a column to denote a magnitude of change based on the modality analysis#1059
Open
kala-moz wants to merge 7 commits into
Open
Bug 2024208: Add a column to denote a magnitude of change based on the modality analysis#1059kala-moz wants to merge 7 commits into
kala-moz wants to merge 7 commits into
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
016f281 to
d4e94a7
Compare
d4e94a7 to
717ce36
Compare
Collaborator
|
Similarly to #1056 (comment) I only see |
Contributor
Author
I've decided to also remove the dash since it doesn't give enough information. I've switched to Ahhh, I didn't use replicates. That's were the bug was. Updated subtests preview |
Mode change: dash to NM instead - No modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Median Diff (%) column has been replaced with a Mode Δ (%) column that reports the largest matched-pair peak shift between the Base and New distributions, derived from the same KDE + mode-detection + modality-matching pipeline that powers the chart and the expanded-row blurb.
LikebootstrapCi, the value is precomputed once in the four data loaders (loader.ts,overTimeLoader.ts,subtestsLoader.ts,subtestsOverTimeLoader.tsx) viaprecomputeLargestPeakShiftand attached toresult.modeDeltaPct. KDE + mode matching is expensive enough that running it on every sort comparison or render would tank interactions.Speedometer 3 preview link
I had some trouble with netlify thus all the open / reopen commands. :/
Update: The Mode Δ (%) column and the Distribution Interpretation row in
MannWhitneyCompareMetricswere reading mode counts from two independent sources: the client-side ISJ/SJ KDE pipeline vs. the backend's wider Silverman KDE. Therefore, could could disagree in jarring ways (e.g. "Mode Δ = 4.16%" sitting directly above "No modes or data, possible oversmoothing"). Now, both views are piped through a single precomputed analysis so they can't drift.Update 2: I precompute modality on replicates when available
Update 3: Flip the sortFunction to ASC semantics so the framework's swap produces the intuitive direction: DESC → biggest improvements first, ASC → biggest regressions first. Comment updated to spell this out (same convention the Sig column already uses).
Update 4: Lazy-precompute Mode Δ analysis to restore load speed. All four loaders no longer call
precomputeModalityAnalysis