-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add stack-safe async loop support with trampoline pattern #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vbabanin
wants to merge
5
commits into
mongodb:main
Choose a base branch
from
vbabanin:JAVA-6120
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
driver-core/src/main/com/mongodb/internal/async/AsyncTrampoline.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Copyright 2008-present MongoDB, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.mongodb.internal.async; | ||
|
|
||
| import com.mongodb.annotations.NotThreadSafe; | ||
| import com.mongodb.lang.Nullable; | ||
|
|
||
| /** | ||
| * A trampoline that converts recursive callback invocations into an iterative loop, | ||
| * preventing stack overflow in async loops. | ||
| * | ||
| * <p>When async loop iterations complete synchronously on the same thread, callback | ||
| * recursion occurs: each iteration's {@code callback.onResult()} immediately triggers | ||
| * the next iteration, causing unbounded stack growth. For example, a 1000-iteration | ||
| * loop would create > 1000 stack frames and cause {@code StackOverflowError}.</p> | ||
| * | ||
| * <p>The trampoline intercepts this recursion: instead of executing the next iteration | ||
| * immediately (which would deepen the stack), it enqueues the continuation and returns, allowing | ||
| * the stack to unwind. A flat loop at the top then processes enqueued continuation iteratively, | ||
| * maintaining constant stack depth regardless of iteration count.</p> | ||
| * | ||
| * <p>Since async chains are sequential, at most one task is pending at any time. | ||
| * The trampoline uses a single slot rather than a queue.</p> | ||
| * | ||
| * The first call on a thread becomes the "trampoline owner" and runs the drain loop. | ||
| * Subsequent (re-entrant) calls on the same thread enqueue their continuation and return immediately.</p> | ||
| * | ||
| * <p>This class is not part of the public API and may be removed or changed at any time</p> | ||
| */ | ||
| @NotThreadSafe | ||
| public final class AsyncTrampoline { | ||
|
|
||
| private static final ThreadLocal<ContinuationHolder> TRAMPOLINE = new ThreadLocal<>(); | ||
|
|
||
| private AsyncTrampoline() {} | ||
|
|
||
| /** | ||
| * Execute continuation through the trampoline. If no trampoline is active, become the owner | ||
| * and drain all enqueued continuations. If a trampoline is already active, enqueue and return. | ||
| */ | ||
| public static void run(final Runnable continuation) { | ||
| ContinuationHolder continuationHolder = TRAMPOLINE.get(); | ||
| if (continuationHolder != null) { | ||
| continuationHolder.enqueue(continuation); | ||
| } else { | ||
| continuationHolder = new ContinuationHolder(); | ||
| TRAMPOLINE.set(continuationHolder); | ||
| try { | ||
| continuation.run(); | ||
| while (continuationHolder.continuation != null) { | ||
| Runnable continuationToRun = continuationHolder.continuation; | ||
| continuationHolder.continuation = null; | ||
| continuationToRun.run(); | ||
| } | ||
| } finally { | ||
| TRAMPOLINE.remove(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * A single-slot container for continuation. | ||
| * At most one continuation is pending at any time in a sequential async chain. | ||
| */ | ||
| @NotThreadSafe | ||
| private static final class ContinuationHolder { | ||
| @Nullable | ||
| private Runnable continuation; | ||
|
|
||
| void enqueue(final Runnable continuation) { | ||
| if (this.continuation != null) { | ||
| throw new AssertionError("Trampoline slot already occupied"); | ||
| } | ||
| this.continuation = continuation; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nextIteration is reused to avoid creation of extra objects via
LambdaMetafactoryas we have the capturing lambda.bounce.work = taskis a write to a heap object's field, which can be considered an automatic escape in the JIT's analysis. Even if theBounceobject is short-lived, the JIT sees "object written to another object's field" and should give up.The
AsyncCallbackLoopJMH GC profiling(OpenJDK 17.0.10 LTS, 64-bit Server VM, mixed mode with compressed oops).For Lambda case:
Per iteration: 1 lambda * 16 bytes = 16 B