fix(enhanced): include duplicate shared fallback versions#4778
Open
2heal1 wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 71a6859 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/metro-plugin-rock
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/observability-plugin
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report10 package(s) changed, 31 unchanged. Package dist + ESM entry
Bundle targets
Consumer scenarios
Total dist (raw): 6.81 MB (+3.6 kB (+0.1%)) Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71a685903f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+258
to
+264
| const shareRequests = Array.from( | ||
| new Map( | ||
| (shareRequestsMap[shareName]?.requests || []).map( | ||
| ([request, version]) => [version, [request, version] as const], | ||
| ), | ||
| ).values(), | ||
| ); |
There was a problem hiding this comment.
When collectInstalledSharedPackageVersions adds more than one version for a shared package, this list feeds the existing inner Promise.all that starts all fallback compilers for that same shareName concurrently. Each of those compilers writes to the same resolveOutputDir(outputDir, shareName) and createIndependentCompiler sets output.clean: true, so one version's emit can be deleted by another version's clean step; the duplicate-version case this change is meant to fix can still leave only the last fallback artifact on disk. Build the versions for a single shared package serially, or avoid cleaning the shared output directory per version.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixes #4748.
Shared tree-shaking fallback generation now supplements the collected root shared package with all installed versions of that same package from
node_modules, including pnpm's.pnpmstore layout. Fallback generation then de-duplicates by version so duplicate installed versions can each get a matching fallback artifact.Why
When a remote used
nanoid@3.3.11through a nested package while the root app hadnanoid@5.1.6, the manifest could point to3.3.11but only a5.1.6fallback was emitted. Runtime then failed because the matching fallback was missing.Validation
pnpm exec prettier --check packages/enhanced/src/lib/sharing/tree-shaking/CollectSharedEntryPlugin.ts packages/enhanced/src/lib/sharing/tree-shaking/IndependentSharedPlugin.ts packages/enhanced/test/unit/sharing/tree-shaking/CollectSharedEntryPlugin.test.ts .changeset/green-shared-fallbacks.mdpnpm --dir packages/enhanced exec rstest test/unit/sharing/tree-shaking/CollectSharedEntryPlugin.test.ts -c rstest.config.tspnpm --filter @module-federation/enhanced run buildpython3.12 .codex/skills/changeset-pr/scripts/run_changeset_status.py --verbosegit diff --checkI also ran the package lint path through the commit hook. It passed with existing package warnings.