Skip to content

fix(enhanced): include duplicate shared fallback versions#4771

Closed
2heal1 wants to merge 1 commit into
mainfrom
codex/fix-4748-shared-fallback-versions
Closed

fix(enhanced): include duplicate shared fallback versions#4771
2heal1 wants to merge 1 commit into
mainfrom
codex/fix-4748-shared-fallback-versions

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented May 28, 2026

What changed

Fixes #4748.

Shared tree-shaking fallback generation now supplements the collected root shared package with all installed versions of that same package from node_modules, including pnpm's .pnpm store layout. Fallback generation then de-duplicates by version so duplicate installed versions can each get a matching fallback artifact.

Why

When a remote used nanoid@3.3.11 through a nested package while the root app had nanoid@5.1.6, the manifest could point to 3.3.11 but only a 5.1.6 fallback was emitted. Runtime then failed because the matching fallback was missing.

Validation

  • pnpm exec prettier --check packages/enhanced/src/lib/sharing/tree-shaking/CollectSharedEntryPlugin.ts packages/enhanced/src/lib/sharing/tree-shaking/IndependentSharedPlugin.ts packages/enhanced/test/unit/sharing/tree-shaking/CollectSharedEntryPlugin.test.ts .changeset/green-shared-fallbacks.md
  • pnpm --dir packages/enhanced exec rstest test/unit/sharing/tree-shaking/CollectSharedEntryPlugin.test.ts -c rstest.config.ts
  • pnpm --filter @module-federation/enhanced run build
  • python3.12 .codex/skills/changeset-pr/scripts/run_changeset_status.py --verbose
  • git diff --check

I also ran the package lint path through the commit hook. It passed with existing package warnings.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit dbdbc23
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/6a17be7e0466c800084aceb3
😎 Deploy Preview https://deploy-preview-4771--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 28, 2026

🦋 Changeset detected

Latest commit: dbdbc23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 46 packages
Name Type
@module-federation/enhanced Patch
@module-federation/modern-js-v3 Patch
@module-federation/modern-js Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/rsbuild-plugin Patch
@module-federation/rspress-plugin Patch
@module-federation/storybook-addon Patch
shared-tree-shaking-no-server-host Patch
shared-tree-shaking-no-server-provider Patch
shared-tree-shaking-with-server-host Patch
shared-tree-shaking-with-server-provider Patch
node-dynamic-remote-new-version Patch
node-dynamic-remote Patch
remote5 Patch
remote6 Patch
website-new Patch
@module-federation/runtime Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/runtime-core Patch
create-module-federation Patch
@module-federation/cli Patch
@module-federation/treeshake-server Patch
@module-federation/treeshake-frontend Patch
@module-federation/metro Patch
@module-federation/metro-plugin-rnef Patch
@module-federation/metro-plugin-rock Patch
@module-federation/metro-plugin-rnc-cli Patch
@module-federation/esbuild Patch
@module-federation/observability-plugin Patch
@module-federation/utilities Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 28, 2026

Open in StackBlitz

@module-federation/devtools

pnpm add https://pkg.pr.new/@module-federation/devtools@dbdbc23

@module-federation/cli

pnpm add https://pkg.pr.new/@module-federation/cli@dbdbc23

create-module-federation

pnpm add https://pkg.pr.new/create-module-federation@dbdbc23

@module-federation/dts-plugin

pnpm add https://pkg.pr.new/@module-federation/dts-plugin@dbdbc23

@module-federation/enhanced

pnpm add https://pkg.pr.new/@module-federation/enhanced@dbdbc23

@module-federation/error-codes

pnpm add https://pkg.pr.new/@module-federation/error-codes@dbdbc23

@module-federation/esbuild

pnpm add https://pkg.pr.new/@module-federation/esbuild@dbdbc23

@module-federation/managers

pnpm add https://pkg.pr.new/@module-federation/managers@dbdbc23

@module-federation/manifest

pnpm add https://pkg.pr.new/@module-federation/manifest@dbdbc23

@module-federation/metro

pnpm add https://pkg.pr.new/@module-federation/metro@dbdbc23

@module-federation/metro-plugin-rnc-cli

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnc-cli@dbdbc23

@module-federation/metro-plugin-rnef

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rnef@dbdbc23

@module-federation/metro-plugin-rock

pnpm add https://pkg.pr.new/@module-federation/metro-plugin-rock@dbdbc23

@module-federation/modern-js

pnpm add https://pkg.pr.new/@module-federation/modern-js@dbdbc23

@module-federation/modern-js-v3

pnpm add https://pkg.pr.new/@module-federation/modern-js-v3@dbdbc23

@module-federation/native-federation-tests

pnpm add https://pkg.pr.new/@module-federation/native-federation-tests@dbdbc23

@module-federation/native-federation-typescript

pnpm add https://pkg.pr.new/@module-federation/native-federation-typescript@dbdbc23

@module-federation/nextjs-mf

pnpm add https://pkg.pr.new/@module-federation/nextjs-mf@dbdbc23

@module-federation/node

pnpm add https://pkg.pr.new/@module-federation/node@dbdbc23

@module-federation/observability-plugin

pnpm add https://pkg.pr.new/@module-federation/observability-plugin@dbdbc23

@module-federation/retry-plugin

pnpm add https://pkg.pr.new/@module-federation/retry-plugin@dbdbc23

@module-federation/rsbuild-plugin

pnpm add https://pkg.pr.new/@module-federation/rsbuild-plugin@dbdbc23

@module-federation/rspack

pnpm add https://pkg.pr.new/@module-federation/rspack@dbdbc23

@module-federation/rspress-plugin

pnpm add https://pkg.pr.new/@module-federation/rspress-plugin@dbdbc23

@module-federation/runtime

pnpm add https://pkg.pr.new/@module-federation/runtime@dbdbc23

@module-federation/runtime-core

pnpm add https://pkg.pr.new/@module-federation/runtime-core@dbdbc23

@module-federation/runtime-tools

pnpm add https://pkg.pr.new/@module-federation/runtime-tools@dbdbc23

@module-federation/sdk

pnpm add https://pkg.pr.new/@module-federation/sdk@dbdbc23

@module-federation/storybook-addon

pnpm add https://pkg.pr.new/@module-federation/storybook-addon@dbdbc23

@module-federation/third-party-dts-extractor

pnpm add https://pkg.pr.new/@module-federation/third-party-dts-extractor@dbdbc23

@module-federation/treeshake-frontend

pnpm add https://pkg.pr.new/@module-federation/treeshake-frontend@dbdbc23

@module-federation/treeshake-server

pnpm add https://pkg.pr.new/@module-federation/treeshake-server@dbdbc23

@module-federation/typescript

pnpm add https://pkg.pr.new/@module-federation/typescript@dbdbc23

@module-federation/utilities

pnpm add https://pkg.pr.new/@module-federation/utilities@dbdbc23

@module-federation/webpack-bundler-runtime

pnpm add https://pkg.pr.new/@module-federation/webpack-bundler-runtime@dbdbc23

@module-federation/bridge-react

pnpm add https://pkg.pr.new/@module-federation/bridge-react@dbdbc23

@module-federation/bridge-react-webpack-plugin

pnpm add https://pkg.pr.new/@module-federation/bridge-react-webpack-plugin@dbdbc23

@module-federation/bridge-shared

pnpm add https://pkg.pr.new/@module-federation/bridge-shared@dbdbc23

@module-federation/bridge-vue3

pnpm add https://pkg.pr.new/@module-federation/bridge-vue3@dbdbc23

@module-federation/inject-external-runtime-core-plugin

pnpm add https://pkg.pr.new/@module-federation/inject-external-runtime-core-plugin@dbdbc23

commit: dbdbc23

@github-actions
Copy link
Copy Markdown
Contributor

Bundle Size Report

10 package(s) changed, 31 unchanged.

Package dist + ESM entry

Package Total dist (raw) Delta ESM gzip Delta
@module-federation/cli 26.3 kB no change 786 B no change
@module-federation/core 39.1 kB no change 173 B no change
@module-federation/devtools 664.0 kB no change 4.0 kB no change
@module-federation/enhanced 811.6 kB +3.6 kB (+0.4%) 672 B no change
@module-federation/managers 69.8 kB no change 334 B no change
@module-federation/manifest 136.1 kB no change 182 B no change
@module-federation/metro-plugin-rnc-cli 0 B no change 314 B no change
@module-federation/node 193.4 kB no change 217 B no change
@module-federation/storybook-addon 77.9 kB no change 100 B no change
@module-federation/utilities 110.6 kB no change 328 B no change

Bundle targets

Package Web bundle (gzip) Delta Node bundle (gzip) Delta
@module-federation/cli 2.3 kB -34 B (-1.4%) 2.3 kB -34 B (-1.4%)
@module-federation/core 1.1 kB -33 B (-2.9%) 1.0 kB -32 B (-3.0%)
@module-federation/devtools 30.2 kB -28 B (-0.1%) 30.2 kB -28 B (-0.1%)
@module-federation/enhanced 2.6 kB -45 B (-1.6%) 2.6 kB -45 B (-1.6%)
@module-federation/managers 2.4 kB -28 B (-1.1%) 2.4 kB -28 B (-1.1%)
@module-federation/manifest 6.1 kB -42 B (-0.7%) 6.1 kB -42 B (-0.7%)
@module-federation/metro-plugin-rnc-cli 411 B -27 B (-6.2%) 411 B -27 B (-6.2%)
@module-federation/node 9.2 kB -29 B (-0.3%) 9.2 kB -29 B (-0.3%)
@module-federation/storybook-addon 1.9 kB -25 B (-1.3%) 1.7 kB -24 B (-1.3%)
@module-federation/utilities 2.6 kB -33 B (-1.2%) 2.6 kB -33 B (-1.2%)

Consumer scenarios

Scenario Web output (gzip) Delta Node output (gzip) Delta Gap (node-web) Delta
Enhanced remoteEntry 21.4 kB -21 B (-0.1%) 22.5 kB -8 B (-0.0%) +1.1 kB +13 B

Total dist (raw): 6.80 MB (+3.6 kB (+0.1%))
Total ESM gzip: 76.6 kB (no change)
Total web bundle (gzip): 205.4 kB (-324 B (-0.2%))
Total node bundle (gzip): 205.9 kB (-322 B (-0.2%))
Tracked ./bundler entry gzip: 556 B (no change)
Tracked ./bundler web bundle (gzip): 4.8 kB (no change)
Tracked ./bundler node bundle (gzip): 4.8 kB (no change)

Bundle sizes are generated with rslib (Rspack). Package-root metrics preserve the historical report. Tracked subpath exports such as ./bundler are measured separately so ENV_TARGET-driven tree-shaking is visible. Bare imports are externalized to keep package-level sizes consistent, and assets are emitted as resources.

Copy link
Copy Markdown
Member Author

2heal1 commented May 28, 2026

Replaced by #4778 to use the required branch naming convention.

@2heal1 2heal1 closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shared tree-shaking fallback generation fails for duplicate package versions

1 participant