Sort filters and add translations for servers#5493
Open
Jerozgen wants to merge 10 commits intomodrinth:mainfrom
Open
Sort filters and add translations for servers#5493Jerozgen wants to merge 10 commits intomodrinth:mainfrom
Jerozgen wants to merge 10 commits intomodrinth:mainfrom
Conversation
Contributor
Jerozgen
commented
Mar 7, 2026
Jerozgen
commented
- Made some server strings translatable
- Removed some unused server strings
- Sorted server categories, regions and languages in the filters
- Fixed issues from Crowdin comments:
- Pokemon → Pokémon
- PVP/PVE → PvP/PvE
- modal.open-in-app.close → button.close
# Conflicts: # packages/ui/src/utils/server-search.ts
Prospector
approved these changes
Mar 8, 2026
Prospector
reviewed
Mar 8, 2026
| status: 'suggestion', | ||
| shouldShow: (context: NagContext) => { | ||
| if (!!context.projectV3?.minecraft_server) return false | ||
| if (context.projectV3?.minecraft_server) return false |
Member
There was a problem hiding this comment.
hrm actually why does this remove the boolean coercion in a few places like this
Contributor
Author
There was a problem hiding this comment.
idk, that's done by prepr:frontend for some reason
Prospector
requested changes
Mar 8, 2026
| defaultMessage: 'Latency', | ||
| ipTooltip: { | ||
| id: `project.about.server.ip.tooltip`, | ||
| defaultMessage: 'Copy Java IP: {ipAddress}', |
Member
There was a problem hiding this comment.
would change this text to "Copy Java server address", we try not to use the word IP for servers
Contributor
Author
There was a problem hiding this comment.
Made changes and removed the {ipAddress} because it seems to be redundant near the address field
# Conflicts: # apps/frontend/src/pages/[type]/[id]/settings/server.vue # packages/ui/src/components/project/server/ServerPing.vue # packages/ui/src/utils/server-search.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.