Add agent-mode tip for enabling agentic browser integration

src/vs/workbench/contrib/chat/browser/chatTipService.ts

@@ -159,6 +159,16 @@ export interface ITipDefinition {
 		/** If true, exclude the tip until the async file check completes. Default: false. */
 		readonly excludeUntilChecked?: boolean;
 	};
+	/**
+	 * Setting keys that, if changed from their default value, make this tip ineligible.
+	 * The tip won't be shown if the user has already customized the setting it describes.
+	 */
+	readonly excludeWhenSettingsChanged?: string[];
+	/**
+	 * Command IDs that dismiss this tip when clicked from the tip markdown
+	 * while the tip is currently shown.
+	 */
+	readonly dismissWhenCommandsClicked?: string[];
 }
 
 /**
@@ -268,6 +278,18 @@ const TIP_CATALOG: ITipDefinition[] = [
 			ContextKeyExpr.notEquals('config.chat.tools.global.autoApprove', true),
 		),
 		enabledCommands: ['workbench.action.openSettings'],
+		dismissWhenCommandsClicked: ['workbench.action.openSettings'],
+	},
+	{
+		id: 'tip.agenticBrowser',
+		message: localize('tip.agenticBrowser', "Tip: Enable [agentic browser integration](command:workbench.action.openSettings?%5B%22workbench.browser.enableChatTools%22%5D) to let the agent open and interact with pages in the Integrated Browser."),
+		when: ContextKeyExpr.and(
+			ChatContextKeys.chatModeKind.isEqualTo(ChatModeKind.Agent),
+			ContextKeyExpr.notEquals('config.workbench.browser.enableChatTools', true),
+		),
+		enabledCommands: ['workbench.action.openSettings'],
+		excludeWhenSettingsChanged: ['workbench.browser.enableChatTools'],
+		dismissWhenCommandsClicked: ['workbench.action.openSettings'],
 	},
 	{
 		id: 'tip.mermaid',
@@ -286,6 +308,8 @@ const TIP_CATALOG: ITipDefinition[] = [
 		message: localize('tip.thinkingPhrases', "Tip: Customize the loading messages shown while the agent works with [thinking phrases](command:workbench.action.openSettings?%5B%22chat.agent.thinking.phrases%22%5D)."),
 		when: ChatContextKeys.chatModeKind.isEqualTo(ChatModeKind.Agent),
 		enabledCommands: ['workbench.action.openSettings'],
+		excludeWhenSettingsChanged: ['chat.agent.thinking.phrases'],
+		dismissWhenCommandsClicked: ['workbench.action.openSettings'],
 	},
 ];
 
@@ -1035,9 +1059,13 @@ export class ChatTipService extends Disposable implements IChatTipService {
 			return;
 		}
 		const enabledCommandSet = new Set(tip.enabledCommands);
+		const dismissCommandSet = new Set(tip.dismissWhenCommandsClicked);
 		this._tipCommandListener.value = this._commandService.onDidExecuteCommand(e => {
 			if (enabledCommandSet.has(e.commandId) && this._shownTip?.id === tip.id) {
 				this._logTipTelemetry(tip.id, 'commandClicked', e.commandId);
+				if (dismissCommandSet.has(e.commandId)) {
+					this.dismissTip();
+				}
 			}
 		});
 	}

src/vs/workbench/contrib/chat/test/browser/chatTipService.test.ts

@@ -967,6 +967,7 @@ suite('ChatTipService', () => {
 
 	for (const { tipId, settingKey } of [
 		{ tipId: 'tip.thinkingPhrases', settingKey: 'chat.agent.thinking.phrases' },
+		{ tipId: 'tip.agenticBrowser', settingKey: 'workbench.browser.enableChatTools' },
 	]) {
 		test(`shows ${tipId} with correct setting link when setting is at default`, async () => {
 			const service = createService();
@@ -989,6 +990,32 @@ suite('ChatTipService', () => {
 		});
 	}
 
+	for (const tipId of [
+		'tip.yoloMode',
+		'tip.thinkingStyle',
+		'tip.thinkingPhrases',
+		'tip.agenticBrowser',
+	]) {
+		test(`dismisses ${tipId} after clicking its settings link`, async () => {
+			const service = createService();
+			contextKeyService.createKey(ChatContextKeys.chatModeKind.key, ChatModeKind.Agent);
+			await new Promise<void>(r => queueMicrotask(r));
+
+			const tip = findTipById(service, tipId);
+			assert.ok(tip, `Should show ${tipId} before command click`);
+
+			let dismissed = false;
+			testDisposables.add(service.onDidDismissTip(() => {
+				dismissed = true;
+			}));
+
+			commandExecutedEmitter.fire({ commandId: 'workbench.action.openSettings', args: [] });
+
+			assert.strictEqual(dismissed, true, `${tipId} should dismiss when its settings command is clicked`);
+			assertTipNeverShown(service, tipId);
+		});
+	}
+
 	test('logs telemetry when tip is shown', () => {
 		const events: { eventName: string; data: Record<string, unknown> }[] = [];
 		instantiationService.stub(ITelemetryService, {